Cherry pick #82
Merged
Cherry pick #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) Now PV will have poolname/parent-dataset info in volume attributes to help to identify the zpool on which PV has been created. ``` $ kubectl describe pv pvc-22d55c56-0c52-4fd5-894c-1f54c4dac5b7 Name: pvc-22d55c56-0c52-4fd5-894c-1f54c4dac5b7 Labels: <none> Annotations: pv.kubernetes.io/provisioned-by: zfs.csi.openebs.io Finalizers: [kubernetes.io/pv-protection] StorageClass: openebs-zfspv Status: Bound Claim: default/pvcname208 Reclaim Policy: Delete Access Modes: RWO VolumeMode: Filesystem Capacity: 4Gi Node Affinity: Required Terms: Term 0: kubernetes.io/hostname in [pawan-2] Message: Source: Type: CSI (a Container Storage Interface (CSI) volume source) Driver: zfs.csi.openebs.io VolumeHandle: pvc-22d55c56-0c52-4fd5-894c-1f54c4dac5b7 ReadOnly: false VolumeAttributes: openebs.io/poolname=zfspv-pool storage.kubernetes.io/csiProvisionerIdentity=1586765686638-8081-zfs.csi.openebs.io Events: <none> ``` Signed-off-by: Pawan <pawan@mayadata.io>
Validating few parameters for the ZFSVolume custom resource - compression can be "on", "off", "lzjb", "gzip", "gzip-[1-9]", "zle" and "lz4" - encryption can be "on", "off", "aes-128-ccm", "aes-192-ccm", "aes-256-ccm", "aes-128-gcm", "aes-192-gcm", and "aes-256-gcm" - dedup can be "on" and "off" - poolname can be string - ownernodeid can be string - thinprovision can be "yes" and "no" - volumetype can be "DATASET" and "ZVOL" Also added required fields needed to create ZFSVolume CR - ownerNodeID - poolname - volumeType - capacity Signed-off-by: Pawan <pawan@mayadata.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick PR to the v0.6.x branch:- #80 and #66