Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

chore: updated Python requirements (REV-2693) #198

Merged
merged 3 commits into from
May 12, 2023
Merged

chore: updated Python requirements (REV-2693) #198

merged 3 commits into from
May 12, 2023

Conversation

ishahroz
Copy link
Contributor

@ishahroz ishahroz commented Apr 26, 2023 •
edited
Loading

⛔️ DEPRECATION WARNING

This repository is deprecated and in maintainence-only operation while we work on a replacement, please see this announcement for more information.

Although we have stopped integrating new contributions, we always appreciate security disclosures and patches sent to security@edx.org

Anyone internally merging to this repository is expected to release and monitor their changes; if you are not able to do this DO NOT MERGE, please coordinate with someone who can to ensure that the changes are released.

Merge checklist:

  • Any new requirements are in the right place (do not manually modify the requirements/*.txt files)
    • base.in if needed in production
    • test.in for test requirements
    • make upgrade && make requirements have been run to regenerate requirements
  • Version bumped

Post merge:

  • Tag pushed and a new version released
    • Note: Assets will be added automatically. You just need to provide a tag (should match your version number) and title and description.
  • After versioned build finishes in GitHub CI, verify version has been pushed to PyPI
    • Each step in the release build has a condition flag that checks if the rest of the steps are done and if so will deploy to PyPi.
      (so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
  • PR created in ecommerce to upgrade dependencies (including ecommerce-worker)
    • This must be done after the version is visible in PyPi as make upgrade in ecommerce will look for the latest version in PyPi.
    • Note: the ecommerce-worker constraint in ecommerce must also be bumped to the latest version in PyPi.
  • Deploy ecommerce
  • Deploy ecomworker on GoCD.
    • While some functions in ecommerce-worker are run via ecommerce, others are handled by a standalone AMI and must be
      released via GoCD.

@ishahroz ishahroz requested a review from a team May 8, 2023 11:16
zubair-ce07
zubair-ce07 approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@zubair-ce07 zubair-ce07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ishahroz ishahroz merged commit 3c37f1e into master May 12, 2023
@ishahroz ishahroz deleted the ishahroz/chore_updated_python_requirements branch May 12, 2023 05:40
pshiu added a commit that referenced this pull request Jun 12, 2023
@pshiu
Revert "chore: updated Python requirements (REV-2693) (#198)"
ba9f681 
This reverts commit 3c37f1e.
grmartin added a commit that referenced this pull request Aug 29, 2023
@grmartin @ishahroz
@pshiu @brobro10000 @zubair-ce07
chore: Syncing 2u/project-theseus with master [2023-08-29] (#207)
a54454b 
* Update standard workflow files. (#195)

* docs: Update the contributing guidelines link. (#197)

We're moving towards a single set of guidelines org-wide.

* chore: updated Python requirements (REV-2693) (#198)

* fix: load config using yaml.safe_load(), not yaml.load() (#202)

Attempt to address exception:

    Traceback (most recent call last):
      File "/edx/app/ecomworker/venvs/ecomworker/bin/celery", line 8, in <module>
        sys.exit(main())
      File "/edx/app/ecomworker/venvs/ecomworker/lib/python3.8/site-packages/celery/__main__.py", line 16, in main
        _main()
      File "/edx/app/ecomworker/venvs/ecomworker/lib/python3.8/site-packages/celery/bin/celery.py", line 322, in main
        cmd.execute_from_commandline(argv)
      File "/edx/app/ecomworker/venvs/ecomworker/lib/python3.8/site-packages/celery/bin/celery.py", line 499, in execute_from_commandline
        super(CeleryCommand, self).execute_from_commandline(argv)))
      File "/edx/app/ecomworker/venvs/ecomworker/lib/python3.8/site-packages/celery/bin/base.py", line 305, in execute_from_commandline
        return self.handle_argv(self.prog_name, argv[1:])
    [...]
      File "/edx/app/ecomworker/venvs/ecomworker/lib/python3.8/site-packages/celery/app/base.py", line 920, in _finalize_pending_conf
        conf = self._conf = self._load_config()
      File "/edx/app/ecomworker/venvs/ecomworker/lib/python3.8/site-packages/celery/app/base.py", line 930, in _load_config
        self.loader.config_from_object(self._config_source)
    [...]
      File "/edx/app/ecomworker/ecomworker/ecommerce_worker/configuration/production.py", line 18, in <module>
        config_from_yaml = yaml.load(f)
    TypeError: load() missing 1 required positional argument: 'Loader'

Docs: https://pyyaml.org/wiki/PyYAMLDocumentation#loading-yaml

* feat: update pypa's publish branch away from master

* chore: added CODEOWNERS file (#199)

Co-authored-by: Muhammad Zubair <syedzubairtahir12@gmail.com>

---------

Co-authored-by: Feanil Patel <feanil@tcril.org>
Co-authored-by: Shahroz Ahmad <97090106+ishahroz@users.noreply.github.com>
Co-authored-by: Phillip Shiu <pshiu@edx.org>
Co-authored-by: Hamzah Ullah <hamzahullah@yahoo.com>
Co-authored-by: Muhammad Zubair <syedzubairtahir12@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zubair-ce07 zubair-ce07 zubair-ce07 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishahroz @zubair-ce07