This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
chore: added CODEOWNERS file to enable branch protection policy (REV-3441) #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zubair-ce07
approved these changes
Jul 7, 2023
grmartin
added a commit
that referenced
this pull request
Aug 29, 2023
* Update standard workflow files. (#195) * docs: Update the contributing guidelines link. (#197) We're moving towards a single set of guidelines org-wide. * chore: updated Python requirements (REV-2693) (#198) * fix: load config using yaml.safe_load(), not yaml.load() (#202) Attempt to address exception: Traceback (most recent call last): File "/edx/app/ecomworker/venvs/ecomworker/bin/celery", line 8, in <module> sys.exit(main()) File "/edx/app/ecomworker/venvs/ecomworker/lib/python3.8/site-packages/celery/__main__.py", line 16, in main _main() File "/edx/app/ecomworker/venvs/ecomworker/lib/python3.8/site-packages/celery/bin/celery.py", line 322, in main cmd.execute_from_commandline(argv) File "/edx/app/ecomworker/venvs/ecomworker/lib/python3.8/site-packages/celery/bin/celery.py", line 499, in execute_from_commandline super(CeleryCommand, self).execute_from_commandline(argv))) File "/edx/app/ecomworker/venvs/ecomworker/lib/python3.8/site-packages/celery/bin/base.py", line 305, in execute_from_commandline return self.handle_argv(self.prog_name, argv[1:]) [...] File "/edx/app/ecomworker/venvs/ecomworker/lib/python3.8/site-packages/celery/app/base.py", line 920, in _finalize_pending_conf conf = self._conf = self._load_config() File "/edx/app/ecomworker/venvs/ecomworker/lib/python3.8/site-packages/celery/app/base.py", line 930, in _load_config self.loader.config_from_object(self._config_source) [...] File "/edx/app/ecomworker/ecomworker/ecommerce_worker/configuration/production.py", line 18, in <module> config_from_yaml = yaml.load(f) TypeError: load() missing 1 required positional argument: 'Loader' Docs: https://pyyaml.org/wiki/PyYAMLDocumentation#loading-yaml * feat: update pypa's publish branch away from master * chore: added CODEOWNERS file (#199) Co-authored-by: Muhammad Zubair <syedzubairtahir12@gmail.com> --------- Co-authored-by: Feanil Patel <feanil@tcril.org> Co-authored-by: Shahroz Ahmad <97090106+ishahroz@users.noreply.github.com> Co-authored-by: Phillip Shiu <pshiu@edx.org> Co-authored-by: Hamzah Ullah <hamzahullah@yahoo.com> Co-authored-by: Muhammad Zubair <syedzubairtahir12@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛔️ DEPRECATION WARNING
This repository is deprecated and in maintainence-only operation while we work on a replacement, please see this announcement for more information.
Although we have stopped integrating new contributions, we always appreciate security disclosures and patches sent to security@edx.org
Anyone internally merging to this repository is expected to release and monitor their changes; if you are not able to do this DO NOT MERGE, please coordinate with someone who can to ensure that the changes are released.
Merge checklist:
requirements/*.txtfiles)base.inif needed in productiontest.infor test requirementsmake upgrade && make requirementshave been run to regenerate requirementsPost merge:
(so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
make upgradein ecommerce will look for the latest version in PyPi.ecommerceecomworkeron GoCD.released via GoCD.