[FC-0014] Add GA 4 support to edX platform #32032
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @UvgenGen! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
Hi @UvgenGen , I'm not sure if you can see the linting errors but it looks like it boils down to:
Which increases the total count:
I'm working on getting front end reviews on both of these PRs today if I can. |
| gtag('config', '{{ ga_4_id }}'); | ||
| </script> | ||
| {% endif %} | ||
|
|
There was a problem hiding this comment.
Looks like some pages were missing GA3 entirely. Nice catch.
There was a problem hiding this comment.
Thank you) Should I add GA3 snippet too?
There was a problem hiding this comment.
I don't think we need to do that for this work. Thanks for checking, though!
|
@bmtcril I pushed new commit with escaping ga_4_id, so now tests should pass) |
UvgenGen
force-pushed
the
sagirov/tCRIL_GA-18
branch
from
5c7e29c to
18b8044
Compare
|
PR rebased |
|
@UvgenGen 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Merge pull request openedx#32032 from raccoongang/sagirov/tCRIL_GA-18 [FC-0014] Add GA 4 support to edX platform Co-authored-by: Brian Mesick <112640379+bmtcril@users.noreply.github.com>
Description
Added support for GA4 to edX platform:
GOOGLE_ANALYTICS_4_ID = "G-TEST"Supporting information