Fix var name issue #762
Fix var name issue #762
Conversation
|
Reviewed in #753 |
| @@ -167,7 +167,7 @@ def upload_asset(request, org, course, coursename): | |||
| sc_partial = partial(StaticContent, content_loc, filename, mime_type) | |||
| if chunked: | |||
| content = sc_partial(upload_file.chunks()) | |||
| temp_filepath = upload_file.temporary_file_path() | |||
| tempfile_path = upload_file.temporary_file_path() | |||
There was a problem hiding this comment.
Does this mean that there's no test that covers this line of code?
There was a problem hiding this comment.
Good point. @jkarni can you address?
There was a problem hiding this comment.
Yeah, the tests were being skipped since something was causing them to fail on Jenkins (though not locally - Jay might have the details). I have another PR [ #766 ] that tries to skip conditionally (if on Jenkins).
There was a problem hiding this comment.
If the tests could be run locally, were they skipping this line, or were you not running them, or did you not notice that they failed?
There was a problem hiding this comment.
Well, it was worse than that. They were both not testing this line (the if-clause) and being skipped. The commit that introduced this bug (mine) changed a whole lot of things, so I didn't notice they were being skipped, nor that this line wasn't being tested. The PR I mentioned adds a test for this line, and makes the test not be skipped locally. Jonah is looking into why exactly the test fails on Jenkins to see if there's a better solution.
make progress label wider
Ayeshabaig/yonk-480
* stv/unfork/superuser: Split superuser_login_as into djangoapp
freetext update
…edx#762) squash!: remove unnecessary styling and migrate to bootstrap and other review feedback
Merge pull request openedx#32032 from raccoongang/sagirov/tCRIL_GA-18 [FC-0014] Add GA 4 support to edX platform Co-authored-by: Brian Mesick <112640379+bmtcril@users.noreply.github.com>
Typo that was preventing >10MB asset uploads