feat: Deduplicate config #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmc-edx
reviewed
Aug 8, 2022
timmc-edx
reviewed
Aug 8, 2022
timmc-edx
reviewed
Aug 8, 2022
timmc-edx
reviewed
Aug 8, 2022
timmc-edx
reviewed
Aug 8, 2022
|
Yeah, in my proof-of-concept branch I had changed the setting names in the new code, but hadn't updated the tests to match. The first part of that was intentional, though. :-) This will also want a CHANGELOG.rst entry and a major-version bump (in the root module's |
timmc-edx
reviewed
Aug 9, 2022
whuang1202
force-pushed
the
common-config
branch
from
c027df5 to
de0d35b
Compare
whuang1202
force-pushed
the
common-config
branch
6 times, most recently
from
347f6ec to
07b534a
Compare
Configuration is put in config.py rather than inside the send to event bus function so it can be more widely used, do note that setting names are changed to have the EVENT_BUS_KAFKA prefix for use.
whuang1202
force-pushed
the
common-config
branch
from
6be135b to
279d194
Compare
whuang1202
changed the title
timmc-edx
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deduplicating configuration into config file
The config file is mostly the same as the common-config given, null checks are added in to the get_producer function in order to accomodate these functions on a separate file.
@timmc-edx when you wrote the override_settings in the test file did you intend for the name of the settings (SCHEMA_REGISTRY_URL for example) to not have EVENT_BUS_KAFKA before it? I couldn't make the tests run as intended without the EVENT_BUS_KAFKA in front of it.