Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic validation on stepper title #893

Closed
wants to merge 2 commits into from
Closed

Conversation

brobro10000
Copy link
Member

https://2u-internal.atlassian.net/browse/ENT-6497

Added validation that a title does exist before proceeding to the next step.
Retains title until the end of the stepper if they proceed
Clears title if they back out of step 1.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 83.35% // Head: 83.37% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (6eaf2da) compared to base (e454868).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #893      +/-   ##
==========================================
+ Coverage   83.35%   83.37%   +0.01%     
==========================================
  Files         378      378              
  Lines        8386     8396      +10     
  Branches     1809     1810       +1     
==========================================
+ Hits         6990     7000      +10     
  Misses       1364     1364              
  Partials       32       32              
Impacted Files Coverage Δ
...nts/ContentHighlights/ContentHighlightsContext.jsx 100.00% <100.00%> (ø)
...ights/HighlightStepper/ContentHighlightStepper.jsx 100.00% <100.00%> (ø)
...hlights/HighlightStepper/HighlightStepperTitle.jsx 100.00% <100.00%> (ø)
src/components/ContentHighlights/data/hooks.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adamstankiewicz
Copy link
Member

Closed in favor of #895

@adamstankiewicz adamstankiewicz deleted the hu/ent-6497 branch November 28, 2022 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants