feat: content highlights stepper updates, including refactor to use context selectors and connects to Algolia for course search results #895
Conversation
Codecov ReportBase: 83.46% // Head: 83.52% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #895 +/- ##
==========================================
+ Coverage 83.46% 83.52% +0.05%
==========================================
Files 386 391 +5
Lines 8581 8727 +146
Branches 1825 1850 +25
==========================================
+ Hits 7162 7289 +127
- Misses 1387 1408 +21
+ Partials 32 30 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
brobro10000
force-pushed
the
hu/ent-6501
branch
2 times, most recently
from
092d636 to
2b29eb0
Compare
brobro10000
force-pushed
the
hu/ent-6501
branch
from
2b29eb0 to
993d97a
Compare
brobro10000
force-pushed
the
hu/ent-6501
branch
from
f83d31e to
d585630
Compare
brobro10000
force-pushed
the
hu/ent-6501
branch
from
af9ec2a to
ba38a2e
Compare
adamstankiewicz
changed the title
| @@ -68,9 +67,11 @@ | |||
| "redux-mock-store": "1.5.4", | |||
| "redux-thunk": "2.3.0", | |||
| "regenerator-runtime": "0.13.7", | |||
| "scheduler": "^0.23.0", | |||
There was a problem hiding this comment.
required peer dependency of use-context-selector below
|
|
||
| const ContentHighlightRoutes = ({ enterpriseSlug }) => { | ||
| const baseContentHighlightPath = `/${enterpriseSlug}/admin/${ROUTE_NAMES.contentHighlights}`; | ||
| return ( | ||
| <> | ||
| <Route | ||
| path={baseContentHighlightPath} | ||
| component={ContentHighlightsDashboard} | ||
| render={(routeProps) => ( | ||
| <BaseContentHighlightRoute {...routeProps}> |
There was a problem hiding this comment.
[note] We will tackle this test coverage in a separate PR.
There was a problem hiding this comment.
Leaving open as a reminder to complete
| return history.push(`/${enterpriseSlug}/admin/${ROUTE_NAMES.contentHighlights}/${highlightSetUUID}`); | ||
| // redirect to individual highlighted set based on uuid | ||
| history.push(`/${enterpriseSlug}/admin/${ROUTE_NAMES.contentHighlights}/${highlightSetUUID}`); | ||
| return; |
There was a problem hiding this comment.
[note] We will tackle this test coverage in a separate PR.
There was a problem hiding this comment.
Leaving open as a reminder to complete
| <p> | ||
| Create up to 8 highlight collections for your learners. | ||
| </p> |
There was a problem hiding this comment.
D'oh, I think this got erroneously deleted somehow, referring to the Figma:
Let's defer on changing in this PR though, as we can treat that as a distinct chunk of work to ensure only 8 highlight sets can be created and add the messaging back in then.
There was a problem hiding this comment.
Leaving open as a reminder to complete
| }; | ||
|
|
||
| const PriceTableCell = ({ row }) => { | ||
| const contentPrice = row.original.firstEnrollablePaidSeatPrice; |
There was a problem hiding this comment.
[note] tests will be added for covered in a future PR
There was a problem hiding this comment.
Leaving open as a reminder to complete
| const handleChange = (e) => { | ||
| if (e.target.value.length > 60) { | ||
| setIsInvalid(true); | ||
| setHighlightTitle({ |
There was a problem hiding this comment.
[note] A test will be added in future PR for this coverage.
There was a problem hiding this comment.
Leaving open as a reminder to complete
| indeterminate, | ||
| checked, | ||
| ...toggleRowSelectedProps | ||
| } = row.getToggleRowSelectedProps(); |
There was a problem hiding this comment.
Test coverage will be added in a separate PR here.
There was a problem hiding this comment.
Leaving open as a reminder to complete
|
|
||
| const SelectContentSelectionStatus = ({ className }) => { | ||
| const { toggleAllRowsSelected } = useContext(DataTableContext); | ||
| const currentSelectedRowsCount = useContextSelector( |
There was a problem hiding this comment.
[note] Test coverage will be added in a future PR here.
There was a problem hiding this comment.
Leaving open as a reminder to complete
brobro10000
force-pushed
the
hu/ent-6501
branch
from
c2ae683 to
100069c
Compare
v2
use-context-selectorfor content highlights, which significantly reduces the performance impacts on component re-rendering when using our architectural approach to using vanilla React context; acts as a polyfill since official support for context selectors is still a proposal).Stepperstep description.Steppersteps.DataTablerow selection when the cap is reached..env.privateto set these environment variables for local development.POSTto/api/v/1/highlight-sets-admin/on final CTA click from "Confirm and publish" step to create highlight, prepending it to any existing highlight sets in theEnterpriseAppContext.enterpriseCurationdata without needing to refresh from API.aggregation_keyconfigured as an attribute for faceting (PR incoming).v1
Added Context, and refactored test/code to pass with context values for title and stepper logic
Initial work on data persist, more work is needed on it at this point
Set up reducer for persisting stepper data
Added logic to title to reflect limit on length of highlight title
Added additional UI changes to match language of the figma
Added reducer for 'Last deleted item' to be used in toast on deletion
For all changes
Only if submitting a visual change