Disable unsyncable expanse chain #10926
Conversation
jam10o-new
added
A0-pleasereview 🤓
|
It looks like @joshua-mir signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
There was a problem hiding this comment.
I'm not sure what to do with this changes...
I believe we should either:
- remove only the command line option (I opt for this)
- remove expanse completely, including the code using transitions. I think we should do this only if we do not plan to bring back expanse in the future
ethcore/res/ethereum/expanse.json
Outdated
| "0xC3500": 3000000 | ||
| }, | ||
| "expip2Transition": "0xC3500", | ||
| "expip2DurationLimit": "0x1E" |
There was a problem hiding this comment.
to remove it fully, we would have to also remove code using those 2 variables
|
Agree somewhat - maybe I should revert everything except 4b6e31f |
jam10o-new
force-pushed
the
jm-remove-expanse
branch
from
0336597
to
9c6ebf2
Compare
@folsen thoughts on this? IMO we should not keep code around because "maybe someday we'll want it back" but I lack some context here. |
|
@dvdplm I generally agree with you and prefer to remove if we think it's unlikely it'll come back. However, I know one of the devs has updated this before and there is some bounty out there to help get this support back in place. I'm not sure how long it's been, given some adequate grace period I would then completely remove. Should it be that someone wants to bring it back, one can always look at history. |
dvdplm
changed the title
|
Ok, let's disable it for the time being and come back and do the rest of the deed in 60 days (I'll set an alarm). |
|
@debris can we get a thumbs up here pls? |
|
@joshua-mir needs a rebase. |
jam10o-new
force-pushed
the
jm-remove-expanse
branch
from
9c6ebf2
to
894309f
Compare
|
We're seeing #10952 in CI 😅 causing a test failure. Looks random. |
* master: [evmbin] fix compilation (#10976) Update to latest trie version. (#10972) [blooms-db] Fix benchmarks (#10974) Fix ethcore/benches build. (#10964) tx-pool: accept local tx with higher gas price when pool full (#10901) Disable unsyncable expanse chain (#10926) Extract Machine from ethcore (#10949) removed redundant state_root function from spec, improve spec error types (#10955) Add support for Energy Web Foundation's new chains (#10957) [evmbin] add more tests to main.rs (#10956) Fix compiler warnings in util/io and upgrade to edition 2018 Upgrade mio to latest (#10953) unify loading spec && further spec cleanups (#10948) refactor: Refactor evmbin CLI (#10742) journaldb changes (#10929) Allow default block parameter to be blockHash (#10932) Enable sealing when engine is ready (#10938) Fix some warnings and typos. (#10941) Updated security@parity.io key (#10939) Change the return type of step_inner function. (#10940)
* master: Verify transaction against its block during import (#10954) [evmbin] fix compilation (#10976) Update to latest trie version. (#10972) [blooms-db] Fix benchmarks (#10974) Fix ethcore/benches build. (#10964) tx-pool: accept local tx with higher gas price when pool full (#10901) Disable unsyncable expanse chain (#10926)
* master: Extract the Engine trait (#10958) Better error message for rpc gas price errors (#10931) [.gitlab.yml] cargo check ethcore benches (#10965) Verify transaction against its block during import (#10954) [evmbin] fix compilation (#10976) Update to latest trie version. (#10972) [blooms-db] Fix benchmarks (#10974) Fix ethcore/benches build. (#10964) tx-pool: accept local tx with higher gas price when pool full (#10901) Disable unsyncable expanse chain (#10926)
Until the necessary features described in #10570 are implemented, expanse appears unsyncable - should probably be removed unless someone wants to do that.