Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix compiler warnings in util/io and upgrade to edition 2018 Upgrade mio to latest #10953

Merged
merged 6 commits into from
Aug 8, 2019

Conversation

dvdplm
Copy link
Collaborator

@dvdplm dvdplm commented Aug 7, 2019

No description provided.

@dvdplm dvdplm self-assigned this Aug 7, 2019
@dvdplm dvdplm added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). labels Aug 7, 2019
Copy link
Contributor

@jam10o-new jam10o-new left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be committing commented out code?

@dvdplm
Copy link
Collaborator Author

dvdplm commented Aug 7, 2019

Should we be committing commented out code?

No we should not. I'm sloppy. Thank you.

dvdplm and others added 3 commits August 7, 2019 16:44
Co-Authored-By: Niklas Adolfsson <niklasadolfsson1@gmail.com>
…rity-ethereum into dp/chore/modernize-util-io

* 'dp/chore/modernize-util-io' of github.com:paritytech/parity-ethereum:
  Update util/io/src/service_mio.rs
@ordian ordian added this to the 2.7 milestone Aug 7, 2019
@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 7, 2019
@niklasad1 niklasad1 merged commit 49f2194 into master Aug 8, 2019
@niklasad1 niklasad1 deleted the dp/chore/modernize-util-io branch August 8, 2019 07:41
dvdplm added a commit that referenced this pull request Aug 8, 2019
* master:
  Fix compiler warnings in util/io and upgrade to edition 2018 Upgrade mio to latest (#10953)
ordian added a commit that referenced this pull request Aug 15, 2019
* master:
  [evmbin] fix compilation (#10976)
  Update to latest trie version. (#10972)
  [blooms-db] Fix benchmarks (#10974)
  Fix ethcore/benches build. (#10964)
  tx-pool: accept local tx with higher gas price when pool full (#10901)
  Disable unsyncable expanse chain (#10926)
  Extract Machine from ethcore (#10949)
  removed redundant state_root function from spec, improve spec error types (#10955)
  Add support for Energy Web Foundation's new chains (#10957)
  [evmbin] add more tests to main.rs (#10956)
  Fix compiler warnings in util/io and upgrade to edition 2018 Upgrade mio to latest (#10953)
  unify loading spec && further spec cleanups (#10948)
  refactor: Refactor evmbin CLI (#10742)
  journaldb changes (#10929)
  Allow default block parameter to be blockHash (#10932)
  Enable sealing when engine is ready (#10938)
  Fix some warnings and typos. (#10941)
  Updated security@parity.io key (#10939)
  Change the return type of step_inner function. (#10940)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants