Type annotation for next_key() matching of json filter options

[lamafab]

Fixes #11189. Very small and easy changes.

Example

"params": [
  15,
  {
    "to": {
        "eq": "0xe8b2d01ffa0a15736b2370b6e5064f9702c891b6"
    },
    "gas": {
        "gt": "0x493e0"
    },
  }
]

curl example:

curl --data '{"method":"parity_pendingTransactions","id": 1,"params":[5,{"from":{"eq":"0x5f3dffcf347944d3739b0805c934d86c8621997f"},"to": {"eq":"0xe8b2d01ffa0a15736b2370b6e5064f9702c891b6"}}],"jsonrpc":"2.0"}' -H "Content-Type: application/json" -X POST localhost:8545

EDIT:
PR for documentation https://github.com/paritytech/wiki/pull/345

[parity-cla-bot]

It looks like @lamafab signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

[ordian]

Thanks!

[niklasad1]

Nice, thank you

Do you mind adding a test for this:

I used the following earlier:

diff --git a/rpc/src/v1/tests/mocked/parity.rs b/rpc/src/v1/tests/mocked/parity.rs
index 913e181e4..35d43b624 100644
--- a/rpc/src/v1/tests/mocked/parity.rs
+++ b/rpc/src/v1/tests/mocked/parity.rs
@@ -322,6 +322,28 @@ fn rpc_parity_pending_transactions() {
        assert_eq!(io.handle_request_sync(request), Some(response.to_owned()));
 }
 
+#[test]
+fn rpc_parity_pending_transactions_with_data_missing_limit() {
+       let deps = Dependencies::new();
+       let io = deps.default_client();
+
+       let request = r#"{"jsonrpc": "2.0", "method": "parity_pendingTransactions", "params":[{"from": {"eq": "0x5f3dffcf347944d3739b0805c934d86c8621997f"}, "to": { "eq": "0xe8b2d01ffa0a15736b2370b6e5064f9702c891b6"}}], "id":1}"#;
+       let response = r#"{"jsonrpc":"2.0","result":[],"id":1}"#;
+
+       assert_eq!(io.handle_request_sync(request), Some(response.to_owned()));
+}
+
+#[test]
+fn rpc_parity_pending_transactions_with_data() {
+       let deps = Dependencies::new();
+       let io = deps.default_client();
+
+       let request = r#"{"jsonrpc": "2.0", "method": "parity_pendingTransactions", "params":[5, {"from": {"eq": "0x5f3dffcf347944d3739b0805c934d86c8621997f"}, "to": { "eq": "0xe8b2d01ffa0a15736b2370b6e5064f9702c891b6"}}], "id":1}"#;
+       let response = r#"{"jsonrpc":"2.0","result":[],"id":1}"#;
+
+       assert_eq!(io.handle_request_sync(request), Some(response.to_owned()));
+}
+
 #[test]
 fn rpc_parity_encrypt() {
        let deps = Dependencies::new();

[lamafab]

Should the tests just cover JSON validity or actually contain filtering logic? I remember trying to do that but had trouble creating sample test transactions. I was told we'll create those eventually, but never got down to it.

(do note that the filter_options already have simple unit tests for JSON validity, but those do not cover the full RPC call, as shown by this bug).

[niklasad1]

Should the tests just cover JSON validity or actually contain filtering logic? I remember trying to do that but had trouble creating sample test transactions. I was told we'll create those eventually, but never got down to it.

All right, the tests should ideally cover filtering logic but JSON deserialization is better than nothing. It is up to you. I see it requires some additional mock code to create some blocks with to and from I suppose. I think something like the following would do it:

	use v1::helpers::fake_sign;
	use types::transaction::*;
	use std::str::FromStr;

	let from: Address = Address::from_str("5f3dffcf347944d3739b0805c934d86c8621997f").unwrap();

	let deps = Dependencies::new();
	{
		let miner = deps.miner.clone();
		for i in 0..10 {
			 // maybe add some different fields here
                         // action field will contain receiver address
                         let tx = Transaction::default().fake_sign(from);
			 // it will have the same hash let's create dummy hash
                         miner.pending_transactions.lock().insert([i as u8; 32].into(), tx);
		}
	}
	let io = deps.default_client();

	let request = r#"{"jsonrpc": "2.0", "method": "parity_pendingTransactions", "params":[1, {"from": {"eq": "0x5f3dffcf347944d3739b0805c934d86c8621997f"}}], "id":1}"#;

[lamafab]

@niklasad1 I just updated the PR. This includes some basic JSON deserialization tests for the pending transactions RPC API. There should be logic tests, which I can try to implement when I have some spare time, but I can't right now.

Also, in the README.md I mentioned to pull the git submodules required for running tests.

[dvdplm]

Does cargo test --all fail without this? I thought it was needed only for cargo test --all --features=json-tests but maybe I'm wrong?

[niklasad1]

Yes, it fails we have this macro which requires the ethereum tests submodule which is used in a couple of the rpc tests

[lamafab]

I don't know if with --all, but it did fail for me when running cargo test -p parity-json

[debris]

neat!