Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

[beta] Backports #8916

Merged
merged 16 commits into from
Jun 19, 2018
Merged

[beta] Backports #8916

merged 16 commits into from
Jun 19, 2018

Conversation

andresilva
Copy link
Contributor

@andresilva andresilva commented Jun 18, 2018

niklasad1 and others added 14 commits June 18, 2018 15:49
* duration_ns: u64 -> duration: Duration

* format on millis {:.2} -> {}
* Keep all enacted blocks notify in order

* Collect is unnecessary

* Update ChainNotify to use ChainRouteType

* Fix all ethcore fn defs

* Wrap the type within ChainRoute

* Fix private-tx and sync api

* Fix secret_store API

* Fix updater API

* Fix rpc api

* Fix informant api

* Eagerly cache enacted/retracted and remove contain_enacted/retracted

* Fix indent

* tests: should use full expr form for struct constructor

* Use into_enacted_retracted to further avoid copy

* typo: not a function

* rpc/tests: ChainRoute -> ChainRoute::new
#8796)

* Add removed geth compatibility field in log

* Fix mocked tests

* Add field block hash in PollFilter

* Store last block hash info for log filters

* Implement canon route

* Use canon logs for fetching reorg logs

Light client removed logs fetching is disabled. It looks expensive.

* Make sure removed flag is set

* Address grumbles
* scripts: enable docker builds for beta and stable

* scripts: docker latest should be beta not master

* scripts: docker latest is master
…s. (#8834)

* Reject transactions that are already in pool without verifying them.

* Avoid verifying already imported transactions.
* Fix concurrent access to signer queue

* Put request back to the queue if confirmation failed

* typo: fix docs and rename functions to be more specific

`request_notify` does not need to be public, and it's renamed to `notify_result`.
`notify` is renamed to `notify_message`.

* Change trace info "Transaction" -> "Request"
* don't allocate via format! in case there's no error

* fix test?
* Add new ovh bootnodes and fix port for foundation bootnode 3.2

* Remove old bootnodes.

* Remove duplicate 1118980bf48b0a3640bdba04e0fe78b1add18e1cd99bf22d53daac1fd9972ad650df52176e7c7d89d1114cfef2bc23a2959aa54998a46afcf7d91809f0855082
Early exit for block nr 0 leads to spurious error about pruning: `…your node is running with state pruning…`.

Fixes #7547, #8762
* fix chain supplier increment

* fix light provider block_headers
@andresilva andresilva added A8-backport 🕸 Pull request is already reviewed well in another branch. M4-core ⛓ Core client code / Rust. labels Jun 18, 2018
@andresilva andresilva changed the base branch from master to beta June 18, 2018 15:20
@andresilva
Copy link
Contributor Author

Added #8524 which was missing the patch label and #8457 as a precursor to it.

@andresilva
Copy link
Contributor Author

Added #8853, needed for #8882.

sorpaas and others added 2 commits June 18, 2018 18:18
…count_provider (#8853)

* Remove unused Result wrap in has_account

* Check whether we need to reseal for external transactions

* Fix reference to has_account interface

* typo: missing )

* Refactor duplicates to prepare_and_update_sealing

* Fix build
…ry (#8882)

* Add tx_queue_allow_unknown_local config option

- Previous commit messages:

dispatcher checks if we have the sender account

Add `tx_queue_allow_unknown_local` to MinerOptions

Add `tx_queue_allow_unknown_local` to config

fix order in MinerOptions to match Configuration

add cli flag for tx_queue_allow_unknown_local

Update refs to `tx_queue_allow_unknown_local`

Add tx_queue_allow_unknown_local to config test

revert changes to dispatcher

Move tx_queue_allow_unknown_local to `import_own_transaction`

Fix var name

if statement should return the values

derp de derp derp derp semicolons

Reset dispatch file to how it was before

fix compile issues + change from FLAG to ARG

add test and use `into`

import MinerOptions, clone the secret

Fix tests?

Compiler/linter issues fixed

Fix linter msg - case of constants

IT LIVES

refactor to omit yucky explict return

update comments

Fix based on diff AccountProvider.has_account method

* Refactor flag name + don't change import_own_tx behaviour

fix arg name

Note: force commit to try and get gitlab tests working again 😠

* Add fn to TestMinerService

* Avoid race condition from trusted sources

- refactor the miner tests a bit to cut down on code reuse
- add `trusted` param to dispatch_transaction and import_claimed_local_transaction

Add param to `import_claimed_local_transaction`

Fix fn sig in tests
@5chdn 5chdn mentioned this pull request Jun 18, 2018
57 tasks
@5chdn
Copy link
Contributor

5chdn commented Jun 19, 2018

Test fails:

failures:

---- v1::tests::mocked::signing::should_check_status_of_request_when_its_resolved stdout ----
	thread 'v1::tests::mocked::signing::should_check_status_of_request_when_its_resolved' panicked at 'assertion failed: `(left == right)` (left: `Some("{\"jsonrpc\":\"2.0\",\"result\":null,\"id\":1}")`, right: `Some("{\"jsonrpc\":\"2.0\",\"result\":\"0x0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001\",\"id\":1}")`, diff: ` Some("{\"jsonrpc\":\"2.0\",\"result\":null,\"id\":1}") Some("{\"jsonrpc\":\"2.0\",\"result\":\"0x0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001\",\"id\":1}") `)', rpc/src/v1/tests/mocked/signing.rs:208:2
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
stack backtrace:
   0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
             at libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
   1: std::sys_common::backtrace::print
             at libstd/sys_common/backtrace.rs:71
             at libstd/sys_common/backtrace.rs:59
   2: std::panicking::default_hook::{{closure}}
             at libstd/panicking.rs:207
   3: std::panicking::default_hook
             at libstd/panicking.rs:217
   4: std::panicking::rust_panic_with_hook
             at libstd/panicking.rs:402
   5: std::panicking::begin_panic_fmt
             at libstd/panicking.rs:349
   6: parity_rpc::v1::tests::mocked::signing::should_check_status_of_request_when_its_resolved
   7: core::ops::function::FnOnce::call_once
   8: <F as alloc::boxed::FnBox<A>>::call_box
             at libtest/lib.rs:1453
             at /checkout/src/libcore/ops/function.rs:223
             at /checkout/src/liballoc/boxed.rs:784
   9: __rust_maybe_catch_panic
             at libpanic_unwind/lib.rs:102


failures:
    v1::tests::mocked::signing::should_check_status_of_request_when_its_resolved

test result: FAILED. 286 passed; 1 failed; 4 ignored; 0 measured; 0 filtered out

@5chdn 5chdn merged commit cc44ae9 into beta Jun 19, 2018
@5chdn 5chdn deleted the andre/beta-backports branch June 19, 2018 08:41
@5chdn
Copy link
Contributor

5chdn commented Jun 19, 2018

Nvm.

@5chdn 5chdn added this to the Patch milestone Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-backport 🕸 Pull request is already reviewed well in another branch. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.