Added --tx-queue-no-early-reject flag to disable early tx queue rejects

[peterbitfly]

This PR resolves #9087 by adding a CLI flag to selectively disable a transaction queue optimization that early rejects transactions below the minimal effective gas price, without comparing the sender to the list of local accounts of a node first.

This allows local transactions to always enter the pool, despite it being full, but requires an additional ecrecover operation on every transaction.

[parity-cla-bot]

It looks like @ppratscher hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, please reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

[peterbitfly]

[clabot:check]

[parity-cla-bot]

It looks like @ppratscher signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

[tomusdrw]

Looks good, minor grumble regarding comments.

Would actually be good to add a simple test for it as well, should be just a copy of min_effective_gas_price test but with local transaction actaully getting into the pool if that setting is on.

[tomusdrw]

Could be named just no_early_reject, we are in the context of tx_queue already.

Also the comment could be a bit more clear :) Maybe something like:

Skip checks for early rejection, to make sure that local transactions are always imported.

[peterbitfly]

Sorry, that comment was a leftover typo. Will fix it & also fix the failing tests.

[peterbitfly]

Sorry but I am unable to find a test named min_effective_gas_price. Which test are you referring to?

[tomusdrw]

@ppratscher was thinking about this test: https://github.com/paritytech/parity/blob/21e0cd7781f55f0007d5c7d87929f49513367e27/miner/src/pool/tests/mod.rs#L987-L1023

Should look somewhat like this:

#[test]
fn should_not_reject_early_in_case_of_local_transaction_and_early_rejections_disabled() {
	// given
	let txq = TransactionQueue::new(
		txpool::Options {
			max_count: 1,
			max_per_sender: 2,
			max_mem_usage: 50
		},
		verifier::Options {
			minimal_gas_price: 1.into(),
			block_gas_limit: 1_000_000.into(),
			tx_gas_limit: 1_000_000.into(),
		},
		PrioritizationStrategy::GasPriceOnly,
	);
	let client = TestClient::new().with_balance(1_000_000_000);
	let tx1 = Tx::gas_price(2).signed().local();

	let res = txq.import(client.clone(), vec![tx1]);
	assert_eq!(res, vec![Ok(())]);
	assert_eq!(txq.status().status.transaction_count, 1);
	assert!(client.was_verification_triggered());

	// when
	let client = TestClient::new();
	let tx1 = Tx::default().signed().local();
	let res = txq.import(client.clone(), vec![tx1]);

	// then
	assert_eq!(res, vec![Ok(())]);
	assert_eq!(txq.status().status.transaction_count, 2);
	assert!(client.was_verification_triggered());
}