Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

fix typo #9232

Merged
merged 1 commit into from
Jul 27, 2018
Merged

fix typo #9232

merged 1 commit into from
Jul 27, 2018

Conversation

dongz9
Copy link
Contributor

@dongz9 dongz9 commented Jul 27, 2018

When a connection is closed, token should be StreamToken instead of TimerToken.

@parity-cla-bot
Copy link

It looks like @dongz9 hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, please reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

Copy link
Collaborator

@sorpaas sorpaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. TimerToken and StreamToken are alias of each other, and in this case indeed it should be StreamToken.

@sorpaas sorpaas added A8-looksgood 🦄 Pull request is reviewed well. A4-clasignoffneeded 📛 Pull request requires author to sign off on CLA before review/merge can begin. M4-core ⛓ Core client code / Rust. labels Jul 27, 2018
@sorpaas sorpaas added this to the 2.1 milestone Jul 27, 2018
@ascjones
Copy link
Contributor

ascjones commented Jul 27, 2018

@dongz9 please sign the CLA (see above) and we can merge this.

@dongz9
Copy link
Contributor Author

dongz9 commented Jul 27, 2018

[clabot:check]

@parity-cla-bot
Copy link

It looks like @dongz9 signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@sorpaas sorpaas removed the A4-clasignoffneeded 📛 Pull request requires author to sign off on CLA before review/merge can begin. label Jul 27, 2018
@sorpaas sorpaas merged commit 5737c21 into openethereum:master Jul 27, 2018
JohnnySheffield added a commit to JohnnySheffield/parity-ethereum that referenced this pull request Jul 27, 2018
* master:
  add changelog for 1.11.8 stable and 2.0.1 beta (openethereum#9230)
  fix typo (openethereum#9232)
  Fix potential as_usize overflow when casting from U256 in miner (openethereum#9221)
  Allow old blocks from peers with lower difficulty (openethereum#9226)
  Removes duplicate libudev-dev from Dockerfile (openethereum#9220)
  snap: remove ssl dependencies from snapcraft definition (openethereum#9222)
  remove ssl from dockerfiles, closes openethereum#8880 (openethereum#9195)
ordian added a commit to ordian/parity that referenced this pull request Jul 31, 2018
* 'master' of https://github.com/paritytech/parity:
  removed client error (openethereum#9253)
  Implement EIP-1052 (EXTCODEHASH) and fix several issues in state account cache (openethereum#9234)
  Improve Tracer documentation (openethereum#9237)
  Update Dockerfile (openethereum#9242)
  block cleanup (openethereum#9117)
  Increase the number of sessions. (openethereum#9203)
  add changelog for 1.11.8 stable and 2.0.1 beta (openethereum#9230)
  fix typo (openethereum#9232)
  Fix potential as_usize overflow when casting from U256 in miner (openethereum#9221)
  Allow old blocks from peers with lower difficulty (openethereum#9226)
  Removes duplicate libudev-dev from Dockerfile (openethereum#9220)
  snap: remove ssl dependencies from snapcraft definition (openethereum#9222)
  remove ssl from dockerfiles, closes openethereum#8880 (openethereum#9195)
  Insert PROOF messages for some cases in blockchain (openethereum#9141)
  [Chain] Add more bootnodes (openethereum#9174)
  ethcore: update bn version (openethereum#9217)
  deserialize block only once during verification (openethereum#9161)
  Simple build instruction fix (openethereum#9215)
  Added --tx-queue-no-early-reject flag to disable early tx queue rejects (openethereum#9143)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants