Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

docker: install missing dependencies in arm target dockerfiles #9436

Merged
merged 1 commit into from
Aug 30, 2018
Merged

docker: install missing dependencies in arm target dockerfiles #9436

merged 1 commit into from
Aug 30, 2018

Conversation

andresilva
Copy link
Contributor

No description provided.

@andresilva andresilva added the A0-pleasereview 🤓 Pull request needs code review. label Aug 30, 2018
@andresilva andresilva requested a review from 5chdn August 30, 2018 01:24
@andresilva
Copy link
Contributor Author

I never know which label to use for docker files: build, ci?

@andresilva andresilva added A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). and removed A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). labels Aug 30, 2018
General-Beck
General-Beck reviewed Aug 30, 2018
View reviewed changes
Copy link
Contributor

@General-Beck General-Beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MB ubuntu:xenial and cmake?

@andresilva
Copy link
Contributor Author

On xenial the cmake package is already at version 3 (https://packages.ubuntu.com/xenial/cmake).

@5chdn 5chdn added M1-ci 🙉 Continuous integration. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 30, 2018
@5chdn 5chdn added this to the 2.1 milestone Aug 30, 2018
@5chdn 5chdn merged commit 07d97d5 into master Aug 30, 2018
@5chdn 5chdn deleted the andre/fix-arm-dockerfiles branch August 30, 2018 18:03
dvdplm added a commit that referenced this pull request Sep 4, 2018
@dvdplm
Merge branch 'master' into dp/chore/fetch-dependencies-from-crates
df88d32 
* master:
  evmbin: escape newlines in json errors (#9458)
  use kvdb-* and parity-snappy crates from crates.io (#9441)
  Add EIP-1014 transition config flag (#9268)
  add tags for runner selection of build-linux jobs (#9451)
  Remove unused BlockStatus::Pending (#9447)
  ci: only include local paths in coverage script (except target) (#9437)
  Add POA Networks: Core and Sokol (#9413)
  docker: install missing dependencies in arm target dockerfiles (#9436)
  Random small cleanups (#9423)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@General-Beck General-Beck General-Beck left review comments

@5chdn 5chdn 5chdn approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

@sorpaas sorpaas sorpaas approved these changes

Assignees
No one assigned
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M1-ci 🙉 Continuous integration.
Projects
None yet
Milestone
2.1 Whatever
Development

Successfully merging this pull request may close these issues.
5 participants
@andresilva @General-Beck @sorpaas @niklasad1 @5chdn