Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

evmbin: escape newlines in json errors #9458

Merged
merged 1 commit into from
Sep 4, 2018
Merged

evmbin: escape newlines in json errors #9458

merged 1 commit into from
Sep 4, 2018

Conversation

ordian
Copy link
Collaborator

@ordian ordian commented Sep 3, 2018

Fixes #9456.

@ordian ordian added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Sep 3, 2018
@ordian ordian requested a review from sorpaas September 3, 2018 13:55
@parity-cla-bot
Copy link

It looks like @ordian signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

sorpaas
sorpaas approved these changes Sep 3, 2018
View reviewed changes
Copy link
Collaborator

@sorpaas sorpaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder whether we should just switch to proper serde serialization/deserialization in the future.

@ordian
Copy link
Collaborator Author

ordian commented Sep 3, 2018

@sorpaas yeah, that seems like a good idea. Feel free to file an issue.

@5chdn 5chdn added this to the 2.1 milestone Sep 3, 2018
@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Sep 3, 2018
@sorpaas sorpaas mentioned this pull request Sep 3, 2018
Closed
@sorpaas sorpaas merged commit 1f24262 into openethereum:master Sep 4, 2018
dvdplm added a commit that referenced this pull request Sep 4, 2018
@dvdplm
Merge branch 'master' into dp/chore/fetch-dependencies-from-crates
df88d32 
* master:
  evmbin: escape newlines in json errors (#9458)
  use kvdb-* and parity-snappy crates from crates.io (#9441)
  Add EIP-1014 transition config flag (#9268)
  add tags for runner selection of build-linux jobs (#9451)
  Remove unused BlockStatus::Pending (#9447)
  ci: only include local paths in coverage script (except target) (#9437)
  Add POA Networks: Core and Sokol (#9413)
  docker: install missing dependencies in arm target dockerfiles (#9436)
  Random small cleanups (#9423)
@ordian ordian deleted the fix/evbmin-json-errors-escape-newlines branch September 4, 2018 10:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sorpaas sorpaas sorpaas approved these changes

@dvdplm dvdplm dvdplm approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
2.1 Whatever
Development

Successfully merging this pull request may close these issues.
5 participants
@ordian @parity-cla-bot @dvdplm @sorpaas @5chdn