fix: data quality - increase threshold for comparison between fiber and its subnutriments #11145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🧽 Data quality
|
alexgarel
deleted the
data-quality/increase-threshold-for-comparison-between-fiber-and-its-subnutriments
branch
stephanegigandet
pushed a commit
that referenced
this pull request
Jan 6, 2025
🤖 I have created a release *beep* *boop* --- ## [2.53.0](v2.52.0...v2.53.0) (2025-01-06) ### Features * data-quality - minimum number of ingredients ([#11152](#11152)) ([d7881d4](d7881d4)), closes [#9732](#9732) * data-quality/apply-remove_insignificant_digits-for-nutriments ([#11147](#11147)) ([a6df72f](a6df72f)) * Top categories for Open Products Facts ([2239473](2239473)) * Top categories for Open Products Facts ([#11171](#11171)) ([2239473](2239473)) ### Bug Fixes * allow serving size to be hyphenated ([#11161](#11161)) ([7c0df2d](7c0df2d)) * Correct indentation, so that CodeQL can work with the code ([#11166](#11166)) ([0178ac2](0178ac2)) * data quality - increase threshold for comparison between fiber and its subnutriments ([#11145](#11145)) ([f0a2682](f0a2682)) * Delete html/images/lang/de/labels/halal.90x90.png ([#11183](#11183)) ([80cf708](80cf708)) * environmental_score ([#11191](#11191)) ([cbe221e](cbe221e)) * fix OPF PR labelling ([e708ae3](e708ae3)) * fix OPF PR labelling ([#11154](#11154)) ([e708ae3](e708ae3)) * fixes for Green-Score ([#11155](#11155)) ([7287d8b](7287d8b)) * green-score link ([#11146](#11146)) ([abf858a](abf858a)) * nutriscore grade from category change for extra virgin olive oils ([#11156](#11156)) ([32d58e0](32d58e0)) * rm nova drilldown field for beauty ([#11193](#11193)) ([3f5b654](3f5b654)) * SonarCloud issues ([#11165](#11165)) ([b84d545](b84d545)) * warnings in import_convert_carrefour_france ([#11189](#11189)) ([4643e3a](4643e3a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Increase the threshold from 0.001 to 0.01
Soluble fiber + insoluble fiber > fiber + 0.01
Related issue(s) and discussion