Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SonarCloud issues #11165

Merged
merged 6 commits into from
Dec 22, 2024
Merged

fix: SonarCloud issues #11165

merged 6 commits into from
Dec 22, 2024

Conversation

hangy
Copy link
Member

@hangy hangy commented Dec 22, 2024

Fix a handful of issues reported by SonarCloud, or add a workaround for the issue.

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.03%. Comparing base (dc04d18) to head (475dc23).
Report is 843 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11165      +/-   ##
==========================================
- Coverage   49.54%   49.03%   -0.52%     
==========================================
  Files          67       78      +11     
  Lines       20650    22374    +1724     
  Branches     4980     5363     +383     
==========================================
+ Hits        10231    10971     +740     
- Misses       9131    10058     +927     
- Partials     1288     1345      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hangy hangy marked this pull request as ready for review December 22, 2024 12:14
@hangy hangy requested a review from a team as a code owner December 22, 2024 12:14
@hangy hangy merged commit b84d545 into openfoodfacts:main Dec 22, 2024
16 checks passed
@hangy hangy deleted the sonarcloud branch December 22, 2024 15:42
stephanegigandet pushed a commit that referenced this pull request Jan 6, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.53.0](v2.52.0...v2.53.0)
(2025-01-06)


### Features

* data-quality - minimum number of ingredients
([#11152](#11152))
([d7881d4](d7881d4)),
closes
[#9732](#9732)
* data-quality/apply-remove_insignificant_digits-for-nutriments
([#11147](#11147))
([a6df72f](a6df72f))
* Top categories for Open Products Facts
([2239473](2239473))
* Top categories for Open Products Facts
([#11171](#11171))
([2239473](2239473))


### Bug Fixes

* allow serving size to be hyphenated
([#11161](#11161))
([7c0df2d](7c0df2d))
* Correct indentation, so that CodeQL can work with the code
([#11166](#11166))
([0178ac2](0178ac2))
* data quality - increase threshold for comparison between fiber and its
subnutriments
([#11145](#11145))
([f0a2682](f0a2682))
* Delete html/images/lang/de/labels/halal.90x90.png
([#11183](#11183))
([80cf708](80cf708))
* environmental_score
([#11191](#11191))
([cbe221e](cbe221e))
* fix OPF PR labelling
([e708ae3](e708ae3))
* fix OPF PR labelling
([#11154](#11154))
([e708ae3](e708ae3))
* fixes for Green-Score
([#11155](#11155))
([7287d8b](7287d8b))
* green-score link
([#11146](#11146))
([abf858a](abf858a))
* nutriscore grade from category change for extra virgin olive oils
([#11156](#11156))
([32d58e0](32d58e0))
* rm nova drilldown field for beauty
([#11193](#11193))
([3f5b654](3f5b654))
* SonarCloud issues
([#11165](#11165))
([b84d545](b84d545))
* warnings in import_convert_carrefour_france
([#11189](#11189))
([4643e3a](4643e3a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants