Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a full edit mode #1161

Closed
teolemon opened this issue Feb 23, 2022 · 15 comments · Fixed by #1167
Closed

Add a full edit mode #1161

teolemon opened this issue Feb 23, 2022 · 15 comments · Fixed by #1167
Assignees
@monsieurtanuki
Labels
✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users.

Comments

@teolemon
Copy link
Member

teolemon commented Feb 23, 2022 •
edited
Loading

Who for

  • Power users

What

  • Add a full edit mode that combines all the editing components (that will also be accessible from more granular prompts)
  • You could enter it from the bottom of the page.
  • The save cancel buttons would be within the section, to keep the components identical to the already existing ones

Mockup

Link to Figma
image

Part of
@teolemon teolemon added ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users. labels Feb 23, 2022
@monsieurtanuki
Copy link
Contributor

Not a big fan of this: the "^" icon on the right means a collapse/expand feature, which does not seem appropriate to me as each edit (e.g. categories) deserves a full screen. I cannot see how to collapse back when the expanded version has dozens of lines - for instance, it's already a bit messy in the preference page.

That said, if you replace each collapse/expand ListTile with an ElevatedButton that opens a new page dedicated to each edit, I can picture that.

@teolemon
Copy link
Member Author

Something like that @monsieurtanuki ?
Edit mode - Delve

@teolemon
Copy link
Member Author

image

@monsieurtanuki
Copy link
Contributor

@teolemon Exactly! Assuming that on that power user mode we open the same edit pages as we do in the normal product page.

@teolemon
Copy link
Member Author

I've made one for packaging, and I'm redoing everything in the style
image

@teolemon
Copy link
Member Author

image

@monsieurtanuki
Copy link
Contributor

How each edit page should look like? That goes beyond the initial purpose of this issue.
But I agree with the concept of an additional power user page that gives access to all edit pages regarding a product.

@teolemon
Copy link
Member Author

yes, indeed, the focus at this point is to have a way to access all sections of editing.

@teolemon
Copy link
Member Author

@monsieurtanuki
Copy link
Contributor

@teolemon Then this issue is about:

  • adding an "edit product" button at the bottom of the product page - assuming that a "power user" is just a user that feels the needs to edit a product (there's no official "hey I'm a power user!" tag, is there?)
  • clicking on the button opens a page with the editable data as list view / list tile
  • each click on a list tile will open a new page that is responsible for editing a single data (e.g. "packaging")

@monsieurtanuki monsieurtanuki self-assigned this Feb 26, 2022
@teolemon
Copy link
Member Author

Everyone should have access to the edit mode, with a prompt to signup or login if you click on it without being logged in

@teolemon teolemon changed the title (Proposal) Add a full edit mode Add a full edit mode Feb 27, 2022
@monsieurtanuki
Copy link
Contributor

@teolemon I've just done it, but now I think that we miss the "edit" notion:
Simulator Screen Shot - iPhone 8 Plus - 2022-02-27 at 18 07 39

Perhaps it's better with a more explicit "edit" icon:
Simulator Screen Shot - iPhone 8 Plus - 2022-02-27 at 18 09 07

Or an even more explicit trailing "edit" button:
Simulator Screen Shot - iPhone 8 Plus - 2022-02-27 at 18 12 03

Or another suggestion, a leading "edit" button:
Simulator Screen Shot - iPhone 8 Plus - 2022-02-27 at 18 13 04

@teolemon
Copy link
Member Author

teolemon commented Feb 27, 2022 •
edited
Loading

The last one might be the one (not too far from my left handed thumb)
Or rewording the first one "Edit labels" "Edit ingredients" …
Honestly, let's get the ball rolling + refine based on feedback

@monsieurtanuki
Copy link
Contributor

OK, let's. For the record the button on the product page looks like this:
Simulator Screen Shot - iPhone 8 Plus - 2022-02-27 at 18 26 52

monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Feb 27, 2022
@monsieurtanuki
feat: openfoodfacts#1161 - created an "edit product" page
0ad7b46 
New file:
* `edit_product_page.dart`: Page where we can indirectly edit all data about a product.

Impacted files:
* `new_product_page.dart`: added a button that calls the new `EditProductPage`
* `Podfile.lock`
@teolemon teolemon mentioned this issue Feb 27, 2022
Merged
monsieurtanuki added a commit that referenced this issue Feb 28, 2022
@monsieurtanuki
feat: #1161 - created an "edit product" page (#1164)
90c1f63 
New file:
* `edit_product_page.dart`: Page where we can indirectly edit all data about a product.

Impacted files:
* `new_product_page.dart`: added a button that calls the new `EditProductPage`
* `Podfile.lock`
@github-actions github-actions bot mentioned this issue Feb 28, 2022
Closed
@monsieurtanuki
Copy link
Contributor

Done in #1164.

monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Feb 28, 2022
@monsieurtanuki
feat: openfoodfacts#1161 - the edit product page now calls the edit n…
872859b 
…utrition page

Impacted files:
* `edit_product_page.dart`: now calling the edit nutrition page; now pops a "changed?" bool; refactored the `ListTile`s
* `knowledge_panels_builder.dart`: refactored with the new cache call
* `new_product_page.dart`: now refreshes the page after edits
* `ordered_nutrients_cache.dart`: refactored as a black box regarding the get/download combo
@monsieurtanuki monsieurtanuki mentioned this issue Feb 28, 2022
Merged
monsieurtanuki added a commit that referenced this issue Mar 3, 2022
@monsieurtanuki
feat: #1161 - the edit product page now calls the edit nutrition page (…
dda3be8 
…#1167)

Impacted files:
* `edit_product_page.dart`: now calling the edit nutrition page; now pops a "changed?" bool; refactored the `ListTile`s
* `knowledge_panels_builder.dart`: refactored with the new cache call
* `new_product_page.dart`: now refreshes the page after edits
* `ordered_nutrients_cache.dart`: refactored as a black box regarding the get/download combo
@monsieurtanuki monsieurtanuki linked a pull request Mar 3, 2022 that will close this issue
feat: #1161 - the edit product page now calls the edit nutrition page #1167
Merged
@teolemon teolemon mentioned this issue Apr 28, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: #1161 - the edit product page now calls the edit nutrition page monsieurtanuki/smooth-app
2 participants
@teolemon @monsieurtanuki