Move the experimental 'category edition' button into the Edit mode

[teolemon]

What

• Move the experimental 'category edition' button currently in the product page into the Edit mode

Mockup

Part of

• Add a full edit mode #1161

[cli1005]

The button "Edit" which works exactly the same way as the "Additional Button" is added to the page Product edition as following:

The "Edit" button is deactivated if the product has no category tag since the "Additional Button" has no action in the same case

category tag exists	category tag missiong

simulator-screen-recording-iphone-13-2022-05-10-at-144404_iok5lYJX.mp4

[teolemon]

Does the category edit mode work ok if we have no category at all ?

[cli1005]

Does the category edit mode work ok if we have no category at all ?

No, the button "Edit" is deactivated, since nothing happens when the "Additional Button" is clicked in this case.

If we have no category as all, the button "Add missing product category" is shown, but no action has been applied yet.

[monsieurtanuki]

@teolemon @cli1005 Actually the current implementation is more or less OK when you want to slightly fix an existing category.

It does not work when you're starting from scratch, the reason being that we don't really have access to root categories:

• the "root" categories (https://world.openfoodfacts.org/api/v2/taxonomy?tagtype=categories&include_root_entries=1&include_children=0&lc=en%2Cfr&cc=fr) are full of crap, like 'en:ayrshire-new-potatoes', 'en:batches-withdrawn-from-retail-stores' or 'en:caviar-substitutes'. We cannot do anything with them.
• in addition to that there are categories without parents, like 'en:plant-based-foods-and-beverages', so we cannot go up to real root categories like a possible 'en:foods-and-beverages' (https://world.openfoodfacts.org/api/v2/taxonomy?tagtype=categories&tags=en%3Aplant-based-foods-and-beverages&include_children=0&lc=en%2Cfr&cc=fr)

Besides, as a user I'm not sure I would bother to climb the category tree step by step, where on the website I can just type "sardines à l'huile" instead of a painful exploration of Conserves, Produits de la mer, Poissons, Poissons en conserve, Poissons et viandes et oeufs, Sardines, Sardines en conserve, Filets de poissons, Sardines à l'huile, Filets de sardines, Sardines à l'huile d'olive, Sardine à l'huile d'olive appertisée

[cli1005]

@teolemon @cli1005 Actually the current implementation is more or less OK when you want to slightly fix an existing category.

It does not work when you're starting from scratch, the reason being that we don't really have access to root categories:

• the "root" categories (https://world.openfoodfacts.org/api/v2/taxonomy?tagtype=categories&include_root_entries=1&include_children=0&lc=en%2Cfr&cc=fr) are full of crap, like 'en:ayrshire-new-potatoes', 'en:batches-withdrawn-from-retail-stores' or 'en:caviar-substitutes'. We cannot do anything with them.
• in addition to that there are categories without parents, like 'en:plant-based-foods-and-beverages', so we cannot go up to real root categories like a possible 'en:foods-and-beverages' (https://world.openfoodfacts.org/api/v2/taxonomy?tagtype=categories&tags=en%3Aplant-based-foods-and-beverages&include_children=0&lc=en%2Cfr&cc=fr)

Besides, as a user I'm not sure I would bother to climb the category tree step by step, where on the website I can just type "sardines à l'huile" instead of a painful exploration of Conserves, Produits de la mer, Poissons, Poissons en conserve, Poissons et viandes et oeufs, Sardines, Sardines en conserve, Filets de poissons, Sardines à l'huile, Filets de sardines, Sardines à l'huile d'olive, Sardine à l'huile d'olive appertisée

We just add a button in the Product Edition page which works the same way as the "Additional Button", no change has been made to the Category Edition :)

[teolemon]

[monsieurtanuki]

@teolemon Not sure I follow you: are we supposed to show this to an end-user that clicks on the "No category so far: please select one" button?

[monsieurtanuki]

We just add a button in the Product Edition page which works the same way as the "Additional Button", no change has been made to the Category Edition :)

@cli1005 It's just that in Category Edition there were cases that were not handled (cf. the TODOs).

[cli1005]

We just add a button in the Product Edition page which works the same way as the "Additional Button", no change has been made to the Category Edition :)

@cli1005 It's just that in Category Edition there were cases that were not handled (cf. the TODOs).

Yes, we might need or have already another issue concerning TODOs of Category Edition? the objective of this issue is just to move the button, in my opinion

[teolemon]

• i was hopping moving the button edit mode forces us to finish the category addition/edition feature, but that might be too blunt an approach
• We need to clean the root server side (We need to cleanup the categories taxonomy root openfoodfacts-server#6763)
• we have an issue to add search to mitigate this, and make @monsieurtanuki 's use case faster (Add a search option to the category edition screen. #1703 )
• Add a confirmation step to the Category Editor before saving (or a save button) #1803
• ideally, it would work for 1st time addition, but complicated due to issue above

[monsieurtanuki]

@teolemon Could also be fixed if 'en:plant-based-foods-and-beverages' had parents (probably the root).

[cli1005]

So... I create a PR juste for the new button or we wait for all the points to reach?

[teolemon]

I've updated my comment with links to the blocking issues. Let's put this one on hold, at least until we clean up server side ?

[teolemon]

Started the clean-up server side @cli1005 @monsieurtanuki @stephanegigandet

• chore: start reducing root categories openfoodfacts-server#6765

[monsieurtanuki]

@teolemon I can start working on the "No category: we start from root" feature, can't I?
Or would we better off (haha) with a "type in/search category" feature?

[teolemon]

Two are equally valid and complementary options.
Search might be slightly more useful in the short term given the wealth of categories

[monsieurtanuki]

@teolemon Have you got some starting point suggestions for the "type in/search category" feature?

[teolemon]

We have the autosuggest API in the Dart package already, and then on click, you could load the partial taxo API matching the selected tag (thus no UI change needed for final validation)

[monsieurtanuki]

@teolemon I know that's not what the mocks said but my brain does not understand the concept of multiple categories on the same tree, UI/UX-wise.

I suggest something similar to the website: the list of the current product categories, and the possibility to add a category with autocomplete.

Something like that:

[teolemon]

I'm not sure I understand how I'm supposed to interact with this new mockup.
Here's for reference my last version, along with search:

At this point of complexity, the solution we have in V1 (field with existing categories as chips, plus the ability to add more thanks to autocomplete) looks more intuitive.

[teolemon]

@monsieurtanuki I've made variants with Radio buttons, but I do believe multiple category selection should remain possible. The second one is in line with the idea that you'd have to pick just one category (removing the list of currently existing categories on a product).

[teolemon]

Also, in the case of single category selection, I'm not sure how we're supposed to handle the thousands of products who do have multiple categories.

[monsieurtanuki]

@teolemon Would you prefer something like this?

[monsieurtanuki]

According to https://openfoodfacts.github.io/api-documentation/#7Metadata

Important! The categories hierarchy is not a tree but a lattice: each node can have several children, but also several parents.

@teolemon That would tend to plead for "type in keywords/search" rather than "tree search", wouldn't it?

[teolemon]

Probably.

[teolemon]

Closing for now, let's focus on adding autocompletion to the current view.