Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary card and question card doesn't honor dark mode #1321

Closed
bhattabhi013 opened this issue Mar 24, 2022 · 10 comments · Fixed by #1323
Closed

Summary card and question card doesn't honor dark mode #1321

bhattabhi013 opened this issue Mar 24, 2022 · 10 comments · Fixed by #1323
Labels
darkmode Ensuring we look good in the dark summary card

Comments

@bhattabhi013
Copy link
Contributor

What

Summary card in product page doesn't honor dark mode.

Steps to reproduce the behavior

  1. Enable dark mode
  2. Search a product, e.g. Tata Premium tea
  3. See error

Expected behavior

Summary card should honor dark mode and text should be clearly visible.

Part of

Screenshot/Mockup/Before-After

image

Smartphone model

@bhattabhi013
Copy link
Contributor Author

I suggest using secondary color as a background to make the text more readable and effective.
E.g.
image

@teolemon
Copy link
Member

ooof, that is an eyesore, with low contrast.
Can you try E1D3C2, both in light and dark mode ?

@bhattabhi013
Copy link
Contributor Author

Yeah sure,
Light mode:
image

Dark mode:
image

@M123-dev
Copy link
Member

We actually have a open PR with that already #1249

@teolemon
Copy link
Member

ah wrong code, I was expecting the global blue of the app

@bhattabhi013
Copy link
Contributor Author

We actually have a open PR with that already #1249

Should I close this ?
I've also noticed something similar after clicking on the question card.
image

@teolemon teolemon added darkmode Ensuring we look good in the dark summary card labels Mar 24, 2022
@monsieurtanuki
Copy link
Contributor

Remember to use onPrimary on primary and onSecondary on secondary. At least the text will be readable.

@bhattabhi013
Copy link
Contributor Author

Should I close this ? I've also noticed something similar after clicking on the question card.

image

After making some changes in the question card , it looks like this:
image

@bhattabhi013
Copy link
Contributor Author

Remember to use onPrimary on primary and onSecondary on secondary. At least the text will be readable.

Hi @monsieurtanuki ,
Question card page's background color is hard coded right now, therefore, it remains same during day and night mode. Should I change it too?

@vik4114
Copy link
Contributor

vik4114 commented Mar 24, 2022

Remember to use onPrimary on primary and onSecondary on secondary. At least the text will be readable.

Hi @monsieurtanuki , Question card page's background color is hard coded right now, therefore, it remains same during day and night mode. Should I change it too?

Yes Just remove hardcoded values and Mostly it will fix these issues

@bhattabhi013 bhattabhi013 changed the title Summary card doesn't honor dark mode Summary card and question card doesn't honor dark mode Mar 24, 2022
M123-dev pushed a commit that referenced this issue Mar 26, 2022
* fix issue 1321

* removed align widget
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
darkmode Ensuring we look good in the dark summary card
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants