fix: Summary card doesn't honor dark mode #1321 #1323
Conversation
| color: const Color(0xfff5f6fa), | ||
| color: Theme.of(context).colorScheme.primary, |
There was a problem hiding this comment.
As said, we already talked about this here but I have to say the primary color looks way too prominent in my opinion. What about completely removing any color for it and using the standart SmoothCard color
There was a problem hiding this comment.
I haven't followed all the thread but remember that there is a secondary color. Maybe we should agree that secondary is for flashy buttons and primary for quieter larger areas?
From https://material.io/design/color/the-color-system.html#color-theme-creation
Secondary colors are best for:
Floating action buttons
Selection controls, like sliders and switches
Highlighting selected text
Progress bars
Links and headlines
There was a problem hiding this comment.
Hi @monsieurtanuki ,
Initially, I tried secondary color but @teolemon suggested to go with primary color. You can find the thread here.
There was a problem hiding this comment.
This is Robotoff, and I'd be tempted to keep the "Robotoff blue" across platforms and versions. @M123-dev @monsieurtanuki @bhattabhi013
There was a problem hiding this comment.
As said, we already talked about this here but I have to say the primary color looks way too prominent in my opinion. What about completely removing any color for it and using the standart SmoothCard color
I tried doing it this way, here is the outcome:
I think we should either go with primary or secondary color as suggested by @monsieurtanuki .
There was a problem hiding this comment.
I have no special interest in specific colors, I was just pointing out that the flutter standards provide 2 main colors. That should be enough for most apps, but if smoothie needs additional colors, why not?
What
fix #1321 : Summary card and question card doesn't honor dark mode.
Screenshot
Fixes bug(s)
Part of
(please be as granular as possible)