Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboard: the first Next button can be spammed #1472

Closed
g123k opened this issue Apr 3, 2022 · 6 comments · Fixed by #1611
Closed

Onboard: the first Next button can be spammed #1472

g123k opened this issue Apr 3, 2022 · 6 comments · Fixed by #1611
Labels
🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…
Milestone

Comments

@g123k
Copy link
Collaborator

g123k commented Apr 3, 2022

What

next.mp4

Steps to reproduce the behavior

  1. Click multiple times on the "Next" button

Expected behavior

The next button should only be clickable 1 time

@g123k g123k added the 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… label Apr 3, 2022
@bhattabhi013
Copy link
Contributor

bhattabhi013 commented Apr 3, 2022

Hi @g123k ,
I suggest using this approach to solve the issue. Please let me know whether I should proceed with it or for any better approach.
cf: https://stackoverflow.com/a/64221837/13595256

@VaiTon
Copy link
Member

VaiTon commented Apr 3, 2022

What if we just disable the button after the first click? The screen shouldn't be reachable anymore after it.

@teolemon
Copy link
Member

teolemon commented Apr 3, 2022

Frankly do we need to block the user to wait for the download ? We do have a local copy of the product in English as a failsafe

@alphaNewrex
Copy link
Contributor

From the point of view of UX, a little Load time is acceptable, but spamming a button feels just like a bug

@M123-dev
Copy link
Member

M123-dev commented Apr 3, 2022

https://api.flutter.dev/flutter/widgets/ModalRoute/barrierDismissible.html

Whether you can dismiss this route by tapping the modal barrier.

showDialog(
  barrierDismissible: false,
  builder: ...
)

@AshAman999
Copy link
Member

https://api.flutter.dev/flutter/widgets/ModalRoute/barrierDismissible.html

Whether you can dismiss this route by tapping the modal barrier.

showDialog(
  barrierDismissible: false,
  builder: ...
)

that would block the user from interacting with the screen, seems like a good idea

@teolemon teolemon added this to the V1 milestone Apr 11, 2022
@teolemon teolemon linked a pull request Apr 22, 2022 that will close this issue
teolemon pushed a commit that referenced this issue Apr 22, 2022
* make dismissible dialogs

* make the onboarding dialog not dismissble
Repository owner moved this from Todo (ready 2 dev) to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…
Development

Successfully merging a pull request may close this issue.

7 participants