Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1472 Stop on boarding next button to get spammed #1611

Merged
merged 2 commits into from
Apr 22, 2022

Conversation

AshAman999
Copy link
Member

What

  • Make the dissimissble to false for dialog if intended to,
  • Implementation of one of the solutions as suggested in the comments,

Screenshot

Record_2022-04-22-18-17-10_cc729dbb1ea2c751a543590b5da9708c.mp4

Fixes bug(s)

@AshAman999 AshAman999 requested a review from a team as a code owner April 22, 2022 12:55
@AshAman999 AshAman999 changed the title fix #1472 Stop on boarding next button to get spammed fix: #1472 Stop on boarding next button to get spammed Apr 22, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1611 (c45325a) into develop (2ea0da3) will decrease coverage by 0.13%.
The diff coverage is 1.50%.

@@            Coverage Diff             @@
##           develop   #1611      +/-   ##
==========================================
- Coverage     8.86%   8.72%   -0.14%     
==========================================
  Files          161     164       +3     
  Lines         6623    6782     +159     
==========================================
+ Hits           587     592       +5     
- Misses        6036    6190     +154     
Impacted Files Coverage Δ
...rds/knowledge_panels/knowledge_panels_builder.dart 2.17% <0.00%> (ø)
...s/product_cards/smooth_product_card_not_found.dart 0.00% <0.00%> (ø)
.../smooth_app/lib/data_models/onboarding_loader.dart 0.00% <ø> (ø)
...mooth_app/lib/data_models/product_query_model.dart 1.38% <ø> (ø)
...s/smooth_app/lib/data_models/user_preferences.dart 34.42% <ø> (+2.11%) ⬆️
...s/smooth_app/lib/database/dao_string_list_map.dart 0.00% <0.00%> (ø)
...ckages/smooth_app/lib/database/local_database.dart 0.00% <0.00%> (ø)
...s/smooth_app/lib/database/paged_product_query.dart 0.00% <0.00%> (ø)
...oth_app/lib/database/robotoff_questions_query.dart 0.00% <0.00%> (ø)
...ric_lib/buttons/smooth_large_button_with_icon.dart 0.00% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bd6be3...c45325a. Read the comment docs.

@teolemon teolemon linked an issue Apr 22, 2022 that may be closed by this pull request
Copy link
Collaborator

@g123k g123k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teolemon teolemon merged commit c203f3a into openfoodfacts:develop Apr 22, 2022
@teolemon
Copy link
Member

merged, thanks @AshAman999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onboard: the first Next button can be spammed
4 participants