Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken preview of the summary card in onboarding #1720

Closed
teolemon opened this issue Apr 29, 2022 · 0 comments
Closed

Broken preview of the summary card in onboarding #1720

teolemon opened this issue Apr 29, 2022 · 0 comments
Assignees
@monsieurtanuki

Comments

@teolemon
Copy link
Member

What

Broken preview of the summary card in onboarding

Screenshot

Screenshot_20220429-225932.png

Part of
@monsieurtanuki monsieurtanuki self-assigned this Apr 30, 2022
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Apr 30, 2022
@monsieurtanuki
fix: openfoodfacts#1720 - now we cannot remove a product from onboarding
b8ebc0b 
There was a Carousel/Provider side-effect.

Impacted files:
* `preferences_page.dart`: used new parameter `isRemovable`
* `product_title_card.dart`: new parameter `isRemovable`
* `summary_card.dart`: new parameter `isRemovable`
@monsieurtanuki monsieurtanuki mentioned this issue Apr 30, 2022
Merged
@github-actions github-actions bot mentioned this issue Apr 30, 2022
Closed
@bhattabhi013 bhattabhi013 mentioned this issue May 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@teolemon @monsieurtanuki