Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1720 - now we cannot remove a product from onboarding #1721

Merged
merged 1 commit into from
Apr 30, 2022

Conversation

monsieurtanuki
Copy link
Contributor

Impacted files:

  • preferences_page.dart: used new parameter isRemovable
  • product_title_card.dart: new parameter isRemovable
  • summary_card.dart: new parameter isRemovable

What

  • We needed an extra parameter to say if this product could be removed from the carousel.
  • That could obviously not happen during the onboarding.
  • The issue was caused by the Carousel provider being called before it was created.

Screenshot

Simulator Screen Shot - iPhone 8 Plus - 2022-04-30 at 08 38 20

Fixes bug(s)

There was a Carousel/Provider side-effect.

Impacted files:
* `preferences_page.dart`: used new parameter `isRemovable`
* `product_title_card.dart`: new parameter `isRemovable`
* `summary_card.dart`: new parameter `isRemovable`
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner April 30, 2022 06:39
@codecov-commenter
Copy link

Codecov Report

Merging #1721 (b8ebc0b) into develop (2ea0da3) will decrease coverage by 0.56%.
The diff coverage is 0.69%.

@@            Coverage Diff             @@
##           develop   #1721      +/-   ##
==========================================
- Coverage     8.86%   8.29%   -0.57%     
==========================================
  Files          161     165       +4     
  Lines         6623    7124     +501     
==========================================
+ Hits           587     591       +4     
- Misses        6036    6533     +497     
Impacted Files Coverage Δ
...h_app/lib/cards/category_cards/abstract_cache.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/asset_cache_helper.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/raster_async_asset.dart 0.00% <0.00%> (ø)
...oth_app/lib/cards/category_cards/raster_cache.dart 0.00% <0.00%> (ø)
..._app/lib/cards/category_cards/svg_async_asset.dart 0.00% <0.00%> (ø)
...smooth_app/lib/cards/category_cards/svg_cache.dart 0.00% <0.00%> (ø)
...t_cards/knowledge_panels/knowledge_panel_card.dart 0.00% <0.00%> (ø)
...t_cards/knowledge_panels/knowledge_panel_page.dart 0.00% <0.00%> (ø)
...knowledge_panels/knowledge_panel_summary_card.dart 0.00% <ø> (ø)
...s/knowledge_panels/knowledge_panel_table_card.dart 0.00% <0.00%> (ø)
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd10bbb...b8ebc0b. Read the comment docs.

@teolemon
Copy link
Member

teolemon commented Apr 30, 2022

Aaaah nice catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants