Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboarding UI/UX fine-tunings #782

Closed
8 tasks done
Tracked by #561
monsieurtanuki opened this issue Dec 28, 2021 · 4 comments
Closed
8 tasks done
Tracked by #561

Onboarding UI/UX fine-tunings #782

monsieurtanuki opened this issue Dec 28, 2021 · 4 comments
Labels
🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 🎨 UI / UX
Milestone
V1

Comments

@monsieurtanuki
Copy link
Contributor

monsieurtanuki commented Dec 28, 2021 •
edited
Loading

ToDo

  • The scan screen on dark mode has day colors
  • The "next" buttons don't have the same color on both welcome and scan pages (but perhaps it was intended so)
  • By the way, maybe we shouldn't care about dark mode here, as the end-user will probably start in day mode
    Simulator Screen Shot - iPhone 8 Plus - 2021-12-28 at 19 11 23

Part of

Done
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Dec 28, 2021
@monsieurtanuki
feature/openfoodfacts#782 - now using the preferences' country (plus …
ebaa914 
…refactoring)

Impacted files:
* `country_selector.dart`: fixed the initial country search (lowercase)
* `knowledge_panels_query.dart`: added language and country as parameters
* `new_product_page.dart`: now computing here language and country
* `product_dialog_helper.dart`: added language and country as parameters
* `product_query.dart`: removed the environment country code
* `smooth_app/pubspec.yaml`: unrelated minor upgrades
* `smooth_app/pubspec.lock`: unrelated minor upgrades
* `example/pubspec.yaml`: unrelated minor upgrades
* `example/pubspec.lock`: unrelated minor upgrades
* `scan_page.dart`: now using the preferences' country
* `search_page.dart`: now computing here language and country
* `user_preferences.dart`: replaced getter `userCountryCode` with `userCountry`
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Dec 28, 2021
@monsieurtanuki
feature/openfoodfacts#782 - now using latest 1.8.1 off-dart library
5c122bd 
Impacted files:
* `product_query.dart`: removed now useless `toLowerCase` call (because of 1.8.1)
* `smooth_app/pubspec.yaml`: upgraded to 1.8.1 off-dart, therefore we can remove the `dependency_overrides` fix
* `smooth_app/pubspec.lock`: impacted by `pubspec.yaml`
* `smooth_ui_library/pubspec.yaml`: upgraded to 1.8.1 off-dart
* `smooth_ui_library/pubspec.lock`: impacted by `pubspec.yaml`
* `example/pubspec.lock`: impacted by `pubspec.yaml`
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Dec 28, 2021
@monsieurtanuki
feature/openfoodfacts#782 - dart analyze fix
6e20e05 
Impacted file:
* `product_dialog_helper.dart`
@M123-dev M123-dev added this to the V 1 milestone Dec 28, 2021
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Dec 29, 2021
@monsieurtanuki
feat: openfoodfacts#782 - now using global country and language
73bcc6e 
Impacted files:
* `barcode_product_query.dart`: now using global country and language
* `continuous_scan_model.dart`: now using implicitly global country and language
* `country_selector.dart`: now setting global country
* `image_upload_card.dart`: now using global language
* `keywords_product_query.dart`: now using global country and language
* `knowledge_panels_query.dart`: now using global country and language
* `main.dart`: now setting global country and language at init time
* `new_product_page.dart`: now using implicitly global country and language
* `product_dialog_helper.dart`: now using implicitly global country and language
* `product_query.dart`: added getter and setter for global country and language
* `scan_page.dart`: now using implicitly global country and language
* `search_page.dart`: now using implicitly global country and language
* `user_preferences.dart`: minor refactoring
monsieurtanuki added a commit that referenced this issue Dec 29, 2021
@monsieurtanuki
feature/#782 - now using the onboarding's country and global country …
2262b4e 
…and language for API searches (#783)

Impacted files:
* `barcode_product_query.dart`: now using global country and language
* `continuous_scan_model.dart`: now using implicitly global country and language
* `country_selector.dart`: fixed the initial country search (lowercase); now setting global country
* `image_upload_card.dart`: now using global language
* `keywords_product_query.dart`: now using global country and language
* `knowledge_panels_query.dart`: now using global country and language
* `main.dart`: now setting global country and language at init time
* `new_product_page.dart`: now using implicitly global country and language
* `product_dialog_helper.dart`: now using implicitly global country and language
* `product_query.dart`: added getter and setter for global country and language
* `smooth_app/pubspec.yaml`: upgraded to 1.8.1 off-dart, therefore we can remove the `dependency_overrides` fix
* `smooth_app/pubspec.lock`: impacted by `pubspec.yaml`
* `smooth_ui_library/pubspec.yaml`: upgraded to 1.8.1 off-dart
* `smooth_ui_library/pubspec.lock`: impacted by `pubspec.yaml`
* `example/pubspec.yaml`: unrelated minor upgrades
* `example/pubspec.lock`: impacted by `pubspec.yaml`
* `scan_page.dart`: now using implicitly global country and language
* `search_page.dart`: now using implicitly global country and language
* `user_preferences.dart`: minor refactoring
This was referenced Jan 1, 2022
Closed
Closed
Merged
@monsieurtanuki monsieurtanuki self-assigned this Jan 4, 2022
@jasmeet0817
Copy link
Contributor

jasmeet0817 commented Jan 4, 2022 •
edited by teolemon
Loading

@monsieurtanuki monsieurtanuki removed their assignment Jan 5, 2022
@teolemon teolemon added 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 🎨 UI / UX labels Jan 15, 2022
@teolemon
Copy link
Member

I reorganized into Done/ToDo, for greater clarity

@teolemon teolemon mentioned this issue Jan 15, 2022
Open
@jasmeet0817
Copy link
Contributor

ToDo

  • The scan screen on dark mode has day colors
  • The "next" buttons don't have the same color on both welcome and scan pages (but perhaps it was intended so)

Since the code is reused, I think this is no longer an issue.

  • By the way, maybe we shouldn't care about dark mode here, as the end-user will probably start in day mode

Yeah, we shouldn't

Simulator Screen Shot - iPhone 8 Plus - 2021-12-28 at 19 11 23

Part of

Done

@monsieurtanuki
Copy link
Contributor Author

We're OK now.
The only thing puzzling me is that on dark mode the welcome page is the same as the light one (therefore a bit too light).
Feel free to open a new issue about it if relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 🎨 UI / UX
Projects
None yet
Milestone
V1
Development

No branches or pull requests
4 participants
@teolemon @jasmeet0817 @monsieurtanuki @M123-dev