Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow long sentences on scan example onboarding page #850

Merged
merged 3 commits into from
Jan 4, 2022

Conversation

jasmeet0817
Copy link
Contributor

Screenshot_1641309593

Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jasmeet0817!
I'm not convinced by the use of Flexible, I guess a Column with MainAxisAlignment.spaceBetween would be safer, but anyway you've fixed the bug, so congratulations!

@jasmeet0817
Copy link
Contributor Author

Hi @jasmeet0817! I'm not convinced by the use of Flexible, I guess a Column with MainAxisAlignment.spaceBetween would be safer, but anyway you've fixed the bug, so congratulations!

depends on your definition of safe :)

You can achieve the column spaceBetween behavior with flex as well, so it's not whether flex is safer or not, but rather the usage of it. I think we are fine now, and flex allows us a lot of device agnoustic layout building capabilities.

@jasmeet0817 jasmeet0817 merged commit 37d4fa1 into openfoodfacts:develop Jan 4, 2022
@monsieurtanuki
Copy link
Contributor

@jasmeet0817 The problem this PR was about was precisely because of Flexible being not 100% agnostic: you have to set a value.
With spaceBetween you would just say: I want the same space between the items, and the items will be 100% displayed and not at all truncated (unless the items are too big and don't fit on the screen, but that's another story, that Flexible wouldn't have dealt with successfully either).

@jasmeet0817
Copy link
Contributor Author

@jasmeet0817 The problem this PR was about was precisely because of Flexible being not 100% agnostic: you have to set a value.
With spaceBetween you would just say: I want the same space between the items, and the items will be 100% displayed and not at all truncated (unless the items are too big and don't fit on the screen, but that's another story, that Flexible wouldn't have dealt with successfully either).

Yeah but spaceBetween is going to give an equal spacing between the elements, which we may or may not want depending upon the UX design. Flex has it's uses, of course we still have to ensure is that each element gets enough space to be rendered on all devices without any clipping.

@jasmeet0817 jasmeet0817 deleted the smallfixes1 branch January 12, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants