Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboarding legibility issue in Dark Mode #875

Closed
1 task
Tracked by #561
, #684 ,  #1171
...
teolemon opened this issue Jan 7, 2022 · 11 comments
Closed
1 task
Tracked by #561
, #684 ,  #1171
...

Onboarding legibility issue in Dark Mode #875

teolemon opened this issue Jan 7, 2022 · 11 comments
Labels
darkmode Ensuring we look good in the dark good first issue Good for newcomers 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 🎨 UI / UX
Milestone
V1

Comments

@teolemon
Copy link
Member

teolemon commented Jan 7, 2022 •
edited
Loading

What

  • Onboarding legibility issue in Dark Mode on iPhone 6S

Part of

Screenshot

image
@teolemon teolemon added 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… darkmode Ensuring we look good in the dark labels Jan 7, 2022
@monsieurtanuki
Copy link
Contributor

@teolemon Just curious: are we talking about real people that launched the app for the very first time, or developers in dev mode? I ask that because I wonder if the app starts in light mode anyway:

  • is there a "dark mode for every app" set-up on iPhone?
  • does smoothie comply to that set-up?

Because if the app automatically inits in light mode, we could ignore issues regarding onboarding in dark mode.

@jasmeet0817
Copy link
Contributor

jasmeet0817 commented Jan 7, 2022 via email

@M123-dev
Copy link
Member

M123-dev commented Jan 7, 2022

Yes it starts in light + blue theme mode, the buttons also look bad for example with green theme. The theme shouldn't be a problem, but at some point we will switch to automatically identifying the system dark mode status and then this will also be on in onboarding.

@M123-dev M123-dev added this to the V 1 milestone Jan 7, 2022
@M123-dev M123-dev changed the title Onboarding legibility issue in Dark Mode on iPhone 6S Onboarding legibility issue in Dark Mode Jan 7, 2022
@teolemon teolemon mentioned this issue Jan 15, 2022
Open
@M123-dev M123-dev mentioned this issue Mar 3, 2022
Closed
12 tasks
@teolemon
Copy link
Member Author

@teolemon teolemon mentioned this issue Mar 19, 2022
Closed
14 tasks
@teolemon
Copy link
Member Author

Partly the same as #1356 which has a PR

@M123-dev
Copy link
Member

Fixed by #1357

Repository owner moved this from Todo (ready 2 dev) to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Mar 29, 2022
@teolemon
Copy link
Member Author

@M123-dev I believe we still have the top title legibility

@M123-dev
Copy link
Member

Yeah thats right @teolemon

@M123-dev M123-dev reopened this Mar 29, 2022
@M123-dev
Copy link
Member

Also the next page button has too less opacity

@teolemon
Copy link
Member Author

Let's open a new issue, possibly

@M123-dev
Copy link
Member

Tracked in #1386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
darkmode Ensuring we look good in the dark good first issue Good for newcomers 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 🎨 UI / UX
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
V1
Development

No branches or pull requests
4 participants
@teolemon @jasmeet0817 @monsieurtanuki @M123-dev