Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Removed hardcoded "See more" color from scan card #1357

Merged
merged 1 commit into from
Mar 28, 2022
Merged

fix: Removed hardcoded "See more" color from scan card #1357

merged 1 commit into from
Mar 28, 2022

Conversation

AshAman999
Copy link
Member

What

  • changed the white color on the info card to theme color so as to honor the dark theme,
  • it appears grey on the dark theme and remains white as usual on a light theme

Screenshot

image

Fixes bug(s)

Part of

@AshAman999 AshAman999 requested a review from a team as a code owner March 28, 2022 06:32
@AshAman999
Copy link
Member Author

@M123-dev was just a single line fix,
please review

@teolemon teolemon added the darkmode Ensuring we look good in the dark label Mar 28, 2022
@teolemon teolemon linked an issue Mar 28, 2022 that may be closed by this pull request
Info card stays white on dark theme #1356
Closed
M123-dev
M123-dev approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @AshAman999

@M123-dev M123-dev changed the title fix: changed the white colour to theme card colour fix: Removed hardcoded "See more" colour from scan card Mar 28, 2022
@M123-dev M123-dev merged commit 98b4271 into openfoodfacts:develop Mar 28, 2022
@M123-dev M123-dev changed the title fix: Removed hardcoded "See more" colour from scan card fix: Removed hardcoded "See more" color from scan card Mar 28, 2022
@github-actions github-actions bot mentioned this pull request Mar 28, 2022
Closed
@M123-dev M123-dev mentioned this pull request Mar 29, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M123-dev M123-dev M123-dev approved these changes

@VaiTon VaiTon VaiTon approved these changes

Assignees
No one assigned
Labels
darkmode Ensuring we look good in the dark
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Info card stays white on dark theme
4 participants
@AshAman999 @VaiTon @M123-dev @teolemon