Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After saving, the Nutrition edit should close, and back to the Product Page #954

Closed
1 task
teolemon opened this issue Jan 14, 2022 · 2 comments
Closed
1 task

After saving, the Nutrition edit should close, and back to the Product Page #954

teolemon opened this issue Jan 14, 2022 · 2 comments
Assignees
@monsieurtanuki
Labels
✏️ Editing - Nutrition input 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users.

Comments

@teolemon
Copy link
Member

teolemon commented Jan 14, 2022 •
edited
Loading

What

  • After saving, the Nutrition edit should close, and the app should bring the user back to the Product Page

Part of
@teolemon teolemon added 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users. ✏️ Editing - Nutrition input labels Jan 14, 2022
@monsieurtanuki monsieurtanuki self-assigned this Jan 17, 2022
@monsieurtanuki
Copy link
Contributor

@teolemon I'm stuck with the following problems:

  1. so far I know how to save a whole product, but I would make sense to save just the nutrition values: is there an API we could call for that? Or could we just save an empty product with just the nutrition values, so that only the nutrition values are saved?
  2. still find confusing the 100g and portion "tabs" - you would like both tab values to be saved, regardless of a tab being displayed or not by the user, right?

@teolemon teolemon moved this to Todo in Road to Scores Feb 11, 2022
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Feb 12, 2022
@monsieurtanuki
feat: openfoodfacts#954 - back to product after saving nutrition facts
971a8aa 
Impacted file:
* `nutrition_page_loaded.dart`: back after saving nutrition facts
monsieurtanuki added a commit that referenced this issue Feb 12, 2022
@monsieurtanuki
feat: #954 - back to product after saving nutrition facts (#1134)
6c60851 
Impacted file:
* `nutrition_page_loaded.dart`: back after saving nutrition facts
@github-actions github-actions bot mentioned this issue Feb 12, 2022
Closed
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Feb 12, 2022
@monsieurtanuki
feat: openfoodfacts#954 - actually saves nutrients on the BE and refr…
6651e8b 
…eshes the local DB

Please run some tests on DEV env to limit the potential impact on PROD!

New file:
* `rainforest-alliance.90x90.svg`: unrelated asset cache refresh

Impacted files:
* `knowledge_panels_builder.dart`: added an optional callback for page refresh after data saving; calls that callback after saving nutrients
* `new_product_page.dart`: added a callback parameter for page refresh
* `nutrition_page_loaded.dart`: actually saves the nutrients on the BE and refreshes the local database
monsieurtanuki added a commit that referenced this issue Feb 13, 2022
@monsieurtanuki
feat: #954 - actually saves nutrients on the BE and refreshes the loc…
4e62659 
…al DB (#1138)

Please run some tests on DEV env to limit the potential impact on PROD!

New file:
* `rainforest-alliance.90x90.svg`: unrelated asset cache refresh

Impacted files:
* `knowledge_panels_builder.dart`: added an optional callback for page refresh after data saving; calls that callback after saving nutrients
* `new_product_page.dart`: added a callback parameter for page refresh
* `nutrition_page_loaded.dart`: actually saves the nutrients on the BE and refreshes the local database
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Feb 14, 2022
@monsieurtanuki
refactor: openfoodfacts#954 - split the nutrition page code for bette…
f40eb35 
…r focus

New file:
* `nutrition_container.dart`: Nutrition data, for nutrient order and conversions.
* `tmp_to_off_nutriments.dart`: Nutrient ids supported by `Nutriments`, to be moved to off-dart

Impacted file:
* `nutrition_page_loaded.dart`: moved the nutrient and conversion code to new class `NutritionContainer`
@monsieurtanuki monsieurtanuki mentioned this issue Feb 14, 2022
Merged
monsieurtanuki added a commit that referenced this issue Feb 18, 2022
@monsieurtanuki
refactor: #954 - split the nutrition page code for better focus (#1142)
0c9552e 
New file:
* `nutrition_container.dart`: Nutrition data, for nutrient order and conversions.
* `tmp_to_off_nutriments.dart`: Nutrient ids supported by `Nutriments`, to be moved to off-dart

Impacted file:
* `nutrition_page_loaded.dart`: moved the nutrient and conversion code to new class `NutritionContainer`
@monsieurtanuki
Copy link
Contributor

Done in #1134.

Repository owner moved this from Todo to Done in Road to Scores Feb 28, 2022
Repository owner moved this from Todo to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Feb 28, 2022
@monsieurtanuki monsieurtanuki mentioned this issue Feb 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
✏️ Editing - Nutrition input 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users.
Projects
Road to Scores
Status: Done
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@teolemon @monsieurtanuki