feat: #954 - actually saves nutrients on the BE and refreshes the local DB #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eshes the local DB Please run some tests on DEV env to limit the potential impact on PROD! New file: * `rainforest-alliance.90x90.svg`: unrelated asset cache refresh Impacted files: * `knowledge_panels_builder.dart`: added an optional callback for page refresh after data saving; calls that callback after saving nutrients * `new_product_page.dart`: added a callback parameter for page refresh * `nutrition_page_loaded.dart`: actually saves the nutrients on the BE and refreshes the local database
teolemon
approved these changes
Feb 12, 2022
|
Thank you @teolemon for your code review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please run some tests on DEV env to limit the potential impact on PROD!
New file:
rainforest-alliance.90x90.svg: unrelated asset cache refreshImpacted files:
knowledge_panels_builder.dart: added an optional callback for page refresh after data saving; calls that callback after saving nutrientsnew_product_page.dart: added a callback parameter for page refreshnutrition_page_loaded.dart: actually saves the nutrients on the BE and refreshes the local database