Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1055 - shorter "history" title #1056

Merged
merged 32 commits into from
Feb 1, 2022
Merged

fix: #1055 - shorter "history" title #1056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
66a4f82
Merge pull request #20 from openfoodfacts/develop
monsieurtanuki Jan 3, 2022
a6ed5fe
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 3, 2022
f1eb63f
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 3, 2022
dd4338a
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 4, 2022
1811829
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 4, 2022
8b14423
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 4, 2022
52b8ae3
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 5, 2022
96bb3f1
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 6, 2022
7840c45
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 6, 2022
241785b
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 6, 2022
edd46be
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 7, 2022
7e6f576
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 8, 2022
32c1433
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 9, 2022
6cc8541
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 10, 2022
d680373
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 10, 2022
c0ea17d
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 13, 2022
b257696
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 13, 2022
2555a12
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 13, 2022
077a938
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 14, 2022
c264e7f
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 14, 2022
f568686
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 17, 2022
07af801
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 18, 2022
f73efb3
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 19, 2022
d141a78
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 20, 2022
791e510
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 22, 2022
e9ab185
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 22, 2022
9cc2025
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 24, 2022
55533c8
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 24, 2022
76283ff
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 27, 2022
8263984
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Jan 31, 2022
8b3ab82
Merge branch 'openfoodfacts:develop' into develop
monsieurtanuki Feb 1, 2022
f808214
fix: #1055 - shorter "history" title
monsieurtanuki Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/smooth_app/lib/l10n/app_en.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@
"@Lists": {},
"no_prodcut_in_list": "There is no product in this list",
"no_product_in_section": "There is no product in this section",
"recently_seen_products": "My recently seen products",
"recently_seen_products": "History",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you maybe add a comment for the translators

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @M123-dev for your review!
I have no idea how translators work and I don't know which details they need: how short is the label supposed to be? on what kind of Widget is it displayed? what is the context?
In a first approach with a tag called "recently_seen_products" and "History" as a translation in English they have 90% of the data they need, I guess.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"This goes to a header, so please keep it short." or something like that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would make sense. Actually so far there are only two labels in app_en.arb with a "keep it short" hint...

"clear": "Clear",
"@clear": {
"description": "Clears a product list"
Expand Down
2 changes: 1 addition & 1 deletion packages/smooth_app/lib/l10n/app_fr.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@
"@Lists": {},
"no_prodcut_in_list": "Il n'y a pas de produit dans cette liste",
"no_product_in_section": "Il n'y a pas de produit dans cette section",
"recently_seen_products": "Mes produits récemment vus",
"recently_seen_products": "Historique",
"clear": "Effacer",
"@clear": {
"description": "Clears a product list"
Expand Down