Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1055 - shorter "history" title #1056

Merged
merged 32 commits into from
Feb 1, 2022

Conversation

monsieurtanuki
Copy link
Contributor

Impacted files:

  • app_en.arb
  • app_fr.arb

Simulator Screen Shot - iPhone 8 Plus - 2022-02-01 at 08 11 56

@@ -491,7 +491,7 @@
"@Lists": {},
"no_prodcut_in_list": "There is no product in this list",
"no_product_in_section": "There is no product in this section",
"recently_seen_products": "My recently seen products",
"recently_seen_products": "History",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you maybe add a comment for the translators

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @M123-dev for your review!
I have no idea how translators work and I don't know which details they need: how short is the label supposed to be? on what kind of Widget is it displayed? what is the context?
In a first approach with a tag called "recently_seen_products" and "History" as a translation in English they have 90% of the data they need, I guess.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"This goes to a header, so please keep it short." or something like that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would make sense. Actually so far there are only two labels in app_en.arb with a "keep it short" hint...

@monsieurtanuki monsieurtanuki merged commit 554eb4d into openfoodfacts:develop Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants