-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #1055 - shorter "history" title #1056
fix: #1055 - shorter "history" title #1056
Conversation
Impacted files: * `app_en.arb` * `app_fr.arb`
@@ -491,7 +491,7 @@ | |||
"@Lists": {}, | |||
"no_prodcut_in_list": "There is no product in this list", | |||
"no_product_in_section": "There is no product in this section", | |||
"recently_seen_products": "My recently seen products", | |||
"recently_seen_products": "History", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you maybe add a comment for the translators
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @M123-dev for your review!
I have no idea how translators work and I don't know which details they need: how short is the label supposed to be? on what kind of Widget is it displayed? what is the context?
In a first approach with a tag called "recently_seen_products" and "History" as a translation in English they have 90% of the data they need, I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"This goes to a header, so please keep it short." or something like that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would make sense. Actually so far there are only two labels in app_en.arb
with a "keep it short" hint...
Impacted files:
app_en.arb
app_fr.arb