feat: #511 - added a "nutrition edit page" #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New files: * `nutrition_page.dart`: Preparatory nutrition page where data is loaded. * `nutrition_page_loaded.dart`: Actual nutrition page, with data already loaded. Impacted files: * `app_en.arb`: added 6 related labels * `app_fr.arb`: added 6 related labels * `knowledge_panels_builder.dart`: now the nutrition page button is systematic (but with a potentially different label/icon) * `new_product_page.dart`: minor refactoring * `product_cards_helper.dart`: minor refactoring * `smooth_app/pubspec.lock` * `smooth_ui_library/pubspec.lock` * `smooth_ui_library/example/pubspec.lock`
teolemon
added
✏️ Editing - Nutrition input
🛣️ Road to scores
M123-dev
approved these changes
Jan 9, 2022
There was a problem hiding this comment.
Just some small comments, the rest looks good, thanks @monsieurtanuki
Impacted files: * `nutrition_page.dart`: refactored with `ProductQuery` * `nutrition_page_loaded.dart`: refactored with `ProductQuery` * `product_query.dart`: new method `getLocaleString`
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still things to do. For the moment we're in read-only mode. Worth merging, though.
New files:
nutrition_page.dart: Preparatory nutrition page where data is loaded.nutrition_page_loaded.dart: Actual nutrition page, with data already loaded.Impacted files:
app_en.arb: added 6 related labelsapp_fr.arb: added 6 related labelsknowledge_panels_builder.dart: now the nutrition page button is systematic (but with a potentially different label/icon)new_product_page.dart: minor refactoringproduct_cards_helper.dart: minor refactoringsmooth_app/pubspec.locksmooth_ui_library/pubspec.locksmooth_ui_library/example/pubspec.lock