feat: #511 - displays both 100g and serving, saves the form with the API #910
+325
−137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orm with the API Impacted files: * `app_en.arb`: added 3 labels * `app_fr.arb`: added 3 labels * `knowledge_panels_builder.dart`: added TODO comment * `nutrition_page_loaded.dart`: * now displays both 100g/serving data at the same time * now validates and save the form with the API
… no API call Impacted file: * `nutrition_page_loaded.dart`
|
@teolemon What I've just committed matches to your latest remarks:
|
M123-dev
approved these changes
Jan 13, 2022
| bool _perServing = false; | ||
| bool _unspecified = false; | ||
| bool _unspecified = false; // TODO(monsieurtanuki): fetch that data from API? | ||
| bool _servingOr100g = false; |
There was a problem hiding this comment.
This is maybe confusing, which value is serving and which is 100g
There was a problem hiding this comment.
I admit that it's not 100% intuitive, but once you've understood the logic you're OK.
I wouldn't use enums for that. Then what? bool _isServing;?
Anyway the story is not over, I'll have numerous opportunities to fix that bool (or replace it altogether).
Thanks for the code review @M123-dev!
Please: if you could also have a look at openfoodfacts/openfoodfacts-dart#362 I could go further (and stop querying the internet systematically).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I strongly suggest anyone willing to test it live to switch to TEST env.
Impacted files:
app_en.arb: added 3 labelsapp_fr.arb: added 3 labelsknowledge_panels_builder.dart: added TODO commentnutrition_page_loaded.dart: