-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename to smirnoff and add changes in smarty pull request #43
Conversation
@davidlmobley |
@bannanc - please set with Nathan to make sure everything gets moved over to I'm OK with it being merged once you guys are ready, and this does not necessarily have to be done all in one PR. |
Another note, SMIRKS is already an acronym, it should be capitalized anywhere in our documentation. I'm trying to keep an eye out and fix it when I see smirks or Smirks.
I added a not in a version comment, I can write a more verbose one with all the changes if we need it.
I renamed all instances of smirff to smirnoff, I'm going to merge for now and I'll check with Nathan about how to change the conda channel with the name change |
Thanks, @bannanc . Will also need to do a new point release for that via the "releases" tab on GitHub. |
This is the same as pull request #232 on smarty