Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename to smirnoff and add changes in smarty pull request #43

Merged
merged 5 commits into from
Apr 5, 2017

Conversation

bannanc
Copy link
Collaborator

@bannanc bannanc commented Apr 5, 2017

This is the same as pull request #232 on smarty

@bannanc bannanc requested a review from davidlmobley April 5, 2017 06:02
@bannanc
Copy link
Collaborator Author

bannanc commented Apr 5, 2017

@davidlmobley
I didn't change in any of the conda things, I just changed the name of the directory and file. Let me know if I should try to fix the conda part (aka get Nathan to help me with it).

@davidlmobley
Copy link
Collaborator

@bannanc - please set with Nathan to make sure everything gets moved over to smirnoff rather than smirff (including package name, stuff in setup.py, conda-recipes/meta.yaml, etc. (It's not actually in THAT many places so you should be able to do most of it yourself, probably by searching the repo for the word smirff!) and then do a new release and push a new build to the conda channel.

I'm OK with it being merged once you guys are ready, and this does not necessarily have to be done all in one PR.

bannanc added 4 commits April 5, 2017 14:26
Another note, SMIRKS is already an acronym, it should be capitalized anywhere in our documentation. I'm trying to keep an eye out and fix it when I see smirks or Smirks.
I added a not in a version comment, I can write a more verbose one with all the changes if we need it.
@bannanc
Copy link
Collaborator Author

bannanc commented Apr 5, 2017

I renamed all instances of smirff to smirnoff, I'm going to merge for now and I'll check with Nathan about how to change the conda channel with the name change

@davidlmobley
Copy link
Collaborator

I renamed all instances of smirff to smirnoff, I'm going to merge for now and I'll check with Nathan about how to change the conda channel with the name change

Thanks, @bannanc . Will also need to do a new point release for that via the "releases" tab on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants