Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static ofImageType ofImageTypeFromPixelFormat() bug! #3407

Closed
yty opened this issue Nov 12, 2014 · 5 comments
Closed

static ofImageType ofImageTypeFromPixelFormat() bug! #3407

yty opened this issue Nov 12, 2014 · 5 comments

Comments

@yty
Copy link

yty commented Nov 12, 2014

Should add more support..

For example:

    case OF_PIXELS_BGR:
        return OF_IMAGE_COLOR;
    case OF_PIXELS_BGRA:
        return OF_IMAGE_COLOR_ALPHA;

Otherwise, use swapRGB() the error..

ofLog(OF_LOG_ERROR,"ofPixels: image type not supported");
@arturoc arturoc added this to the 0.9.0 milestone Nov 12, 2014
@arturoc
Copy link
Member

arturoc commented Nov 12, 2014

can you send a PR?

@kylemcdonald
Copy link
Contributor

also, @yty i see you on github a lot but never on the of-dev list. can you sign up here?

http://dev.openframeworks.cc/listinfo.cgi/of-dev-openframeworks.cc

@yty
Copy link
Author

yty commented Nov 14, 2014

@arturoc
I created PR. But there are a lot of useless information, I do not know what change is removed. . .
#3413

@kylemcdonald
I just signed up, but did not receive mail.

@kylemcdonald
Copy link
Contributor

@yty i just spoke with theo and you should be signed up now

@kylemcdonald
Copy link
Contributor

i re-added the two relevant lines by hand.

i noticed @yty also commented out the pixel swapping part of swapRgb(), i think the suggestion is that with the way pixel formats work now, maybe we don't need to swap actual memory anymore. but i left it as it is instead of commenting it out :)

K0j0 pushed a commit to K0j0/openFrameworks that referenced this issue Jan 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants