Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix ofImageTypeFromPixelFormat()& swapRgb() #3413

Closed

Conversation

yty
Copy link

@yty yty commented Nov 14, 2014

If not repaired, will not achieve the following example:


ofImage img;
ofImage imgEx;

//--------------------------------------------------------------
void ofApp::setup(){

    ofSetDataPathRoot("E:/GitHubFiles/openFrameworks/examples/graphics/imageLoaderExample/bin/data/images/");

    img.loadImage("transparency.png");
}

//--------------------------------------------------------------
void ofApp::update(){
    imgEx.setFromPixels(img.getPixelsRef(),img.width,img.height,OF_IMAGE_COLOR_ALPHA,ofGetMousePressed()); 
}

//--------------------------------------------------------------
void ofApp::draw(){
    img.draw(0,0);
    imgEx.draw(0,img.getHeight());
}

@kylemcdonald
Copy link
Contributor

same issue here, we would like to merge 9d8d8e5 but the other commits make this a bit complicated. please re-submit with only 9d8d8e5 on top of openframeworks/master

@bilderbuchi
Copy link
Member

also, please follow the guidelines in the contribution document, i.e. prepare a separate branch for each PR, then issues such as this can be more easily avoided. :-)

@yty yty deleted the bugfix-ofImageTypeFromPixelFormat branch November 25, 2014 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants