Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mac OF_TTF_SANS changed #5865

Closed
kylemcdonald opened this issue Feb 1, 2018 · 4 comments
Closed

Mac OF_TTF_SANS changed #5865

kylemcdonald opened this issue Feb 1, 2018 · 4 comments
Assignees
@ofTheo
Milestone
0.10.0

Comments

@kylemcdonald
Copy link
Contributor

kylemcdonald commented Feb 1, 2018 •
edited
Loading

On TARGET_OSX, OF_TTF_SANS corresponds to:

fontname = "Helvetica Neue";
fontID = 4;

But the way this font looks has changed at some point (either 10.12 or 10.13 I believe).

Here are some variations, from fontId 6 to 0:

fontid 6

fontid 5

fontid 4

fontid 3

fontid 2

fontid 1

fontid 0

I suggest changing it to fontId 0 (the final image).
@ofTheo
Copy link
Member

ofTheo commented Feb 6, 2018

Agree!

@ofTheo ofTheo self-assigned this Feb 6, 2018
@ofTheo ofTheo added this to the 0.10.0 milestone Feb 6, 2018
@ofTheo ofTheo mentioned this issue Feb 6, 2018
Closed
27 tasks
@arturoc
Copy link
Member

arturoc commented Feb 6, 2018

@ofTheo can you change it?

@ofTheo
Copy link
Member

ofTheo commented Feb 6, 2018 via email

@ofZach
Copy link
Contributor

ofZach commented Feb 6, 2018 •
edited
Loading

I haven't dug into this but I wonder if it's related to OSX listing files different under APFS vs the previous file system. see also

#5852

@ofTheo ofTheo mentioned this issue Feb 8, 2018
Merged
@arturoc arturoc closed this as completed in 73bd0d8 Feb 8, 2018
arturoc added a commit that referenced this issue Feb 8, 2018
@arturoc
Merge pull request #5877 from ofTheo/bugfix-ttf-font-default
1b7081c 
fix for OS X OF_TTF_SANS default on 10.13 closes #5865
@cuinjune cuinjune mentioned this issue Jul 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ofTheo ofTheo

Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

Update from original (#1)
4 participants
@arturoc @ofZach @ofTheo @kylemcdonald