Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XCode 9.2 can't open project after update 7b87f643f #6172

Closed
dimitre opened this issue Nov 9, 2018 · 12 comments
Closed

XCode 9.2 can't open project after update 7b87f643f #6172

dimitre opened this issue Nov 9, 2018 · 12 comments
Assignees

Comments

@dimitre
Copy link
Member

dimitre commented Nov 9, 2018

XCode 9.2 can't open project after update 7b87f64
Project xxx.xcodeproj cannot be opened because the project file cannot be parsed.

@ofTheo
Copy link
Member

ofTheo commented Nov 10, 2018

Thanks @dimitre
Thats strange that it doesn't open the project for you. From other reports it works with Xcode 9.4.1 it just doesn't read the keys correctly on 10.14.

will look into this though and see if there is a fix that works for all versions.

@ofTheo ofTheo self-assigned this Nov 10, 2018
@ofTheo
Copy link
Member

ofTheo commented Nov 10, 2018

Hmm. I just realized I am on Xcode 9.2 ( and 10.13 ) and I can open and build projects fine.
Are you on 10.14?

Can you try this RC build and see if the examples work for you on Xcode 9.2?

https://openframeworks.cc/versions/mojave/of_v0.10.0-patch-mojave-rc3_osx_release.zip

screen shot 2018-11-10 at 10 02 41 am

@dimitre
Copy link
Member Author

dimitre commented Nov 10, 2018

Hello @ofTheo thanks for the attention on this issue.
I'm in OS X 10.12 (I know, abandonware :)) and XCode 9.2

I've downloaded the patch release and project opens here without issues.

Unrelated to the issue:
in this project generator even after I set the openframeworks path in PG settings, it tries to create in your path /Users/theo/Downloads/...

Thank you

screen shot 2018-11-10 at 7 17 26 pm
screen shot 2018-11-10 at 7 17 22 pm

@ofTheo
Copy link
Member

ofTheo commented Nov 10, 2018

oops! thanks @dimitre - I think I know what I did there.
I'll re-upload the zip.

Thanks!!
Theo

@ofTheo ofTheo closed this as completed Nov 10, 2018
@dimitre
Copy link
Member Author

dimitre commented Nov 10, 2018

Hey @ofTheo I've just noticed the issue is more specific to projects containing ofxSyphon.
https://github.com/astellato/ofxSyphon
I've just tried again with your RC3 and the issue appears there too (when using ofxSyphon)
Thank you

@ofTheo ofTheo reopened this Nov 10, 2018
@ofTheo
Copy link
Member

ofTheo commented Nov 10, 2018

Hi @dimitre
I see it too here. I think it is something to do with the new Xcode project structure and the pbxproj file and the syphon addon. The pbxproj file looks valid to me, but I get the same error.

Will try and dig into it here.

Thanks for reporting this!
Let me know if you see the issue with any other addons.

@dimitre
Copy link
Member Author

dimitre commented Nov 10, 2018

I'm investigating all addons here (listed with ls -1) and already found some other problematic ones

ofxAVFVideoPlayer
ofxAudioAnalyzer
ofxAudioUnit
ofxMidi

I'll edit this same message with other ones later

@ofTheo
Copy link
Member

ofTheo commented Nov 11, 2018

I think I see the issue.

Doing a diff between an example with no addons and ofxSyphon I see a its inserting a new tag before the closing tag instead of after it for FRAMEWORK_SEARCH_PATHS.

screen shot 2018-11-10 at 5 19 01 pm

Going to try and track this down. It could be in the Project Generator code thats changed since 0.10.0 or in the xcode template file we're using.

Thanks for your help!

@ofTheo
Copy link
Member

ofTheo commented Nov 11, 2018

Okay I have a PR for the issue.
It was several things that got changed when we removed the OF sub project from the Xcode template.

The array tags got removed and also the key the PG used to search for the link frameworks section was removed.

Here is the PR. #6174
Will also merge with master if it works.

@ofTheo
Copy link
Member

ofTheo commented Nov 11, 2018

@dimitre if you want to check it out. Grab this file: https://github.com/openframeworks/openFrameworks/blob/99b80ad9c77f9d1d4426cb96d504f9aaf6dc8c95/scripts/templates/osx/emptyExample.xcodeproj/project.pbxproj

And update it in your local copy then run the Project Generator.
The Syphon and other projects should open now.

Thanks again for reporting this!
It was a big bug that none of the CI Tests or my own tests picked up :)

@dimitre
Copy link
Member Author

dimitre commented Nov 11, 2018

I've just tested with this project file and it works!
Thanks for all the effort

A tiny suggestion: it would be great to have inside the XCode project the openFrameworks folder closed by default. The addons one opened by default is great!

screen shot 2018-11-11 at 12 21 59 pm

@dimitre dimitre closed this as completed Nov 11, 2018
@ofTheo
Copy link
Member

ofTheo commented Nov 11, 2018

Thanks @dimitre - will take a look!
Mostly want to get it working first, but if its easy to do I agree that would be better!

olekristensen added a commit to olekristensen/openFrameworks that referenced this issue Jan 2, 2019
* commit 'faeb05d54647915464dcf2bf23ee9da03d8abcd5': (54 commits)
  changelog and thanks scripts
  fixed thanks format
  THANKS.md
  create_package: pull OF from github instead of local
  create_package: pull OF from github instead of local
  Revert "ofConstants: revert version to 0.10.1"
  create_package: pull PG from master always
  PG latest commit
  changelof for 0.10.1
  ofTruetypeFont: Fix kerning factor. openframeworks#6136
  ofConstants: revert version to 0.10.1
  ofSoundBuffer getChannel fix (openframeworks#6117)
  ofSoundBuffer getChannel fix (openframeworks#6117)
  ofxGui: slider scrolling (openframeworks#6144)
  ofxGui: slider scrolling (openframeworks#6144)
  appveyor: fix ssl dependencies (openframeworks#6170)
  appveyor: fix ssl dependencies (openframeworks#6170)
  fix for xcode template file to allow PG to add frameworks and fix broken projects. closes openframeworks#6172
  workspace files for xcode template to enable legacy build in Xcode 10
  added camera and microphone permissions for mojave
  ...

# Conflicts:
#	apps/projectGenerator
olekristensen added a commit to olekristensen/openFrameworks that referenced this issue Jan 2, 2019
…orks into stable

* 'stable' of https://github.com/openframeworks/openFrameworks: (105 commits)
  create_package: pull OF from github instead of local
  create_package: pull PG from master always
  PG latest commit
  changelof for 0.10.1
  ofTruetypeFont: Fix kerning factor. openframeworks#6136
  ofConstants: revert version to 0.10.1
  ofSoundBuffer getChannel fix (openframeworks#6117)
  ofxGui: slider scrolling (openframeworks#6144)
  appveyor: fix ssl dependencies (openframeworks#6170)
  fix for xcode template file to allow PG to add frameworks and fix broken projects. closes openframeworks#6172
  workspace files for xcode template to enable legacy build in Xcode 10
  added camera and microphone permissions for mojave
  fix drawArrow internal matrix calculation (openframeworks#6164)
  remove i386 architecture (openframeworks#6159)
  Revert "Update main.cpp (openframeworks#6150)" (openframeworks#6160)
  Update main.cpp (openframeworks#6150)
  fixes xcode template to not have OF as a dependcy but as a pre-build script. related to openframeworks#6139
  ofCamera with ortho enabled will respect a lensOffset by translating the projection matrix (openframeworks#6138)
  ofXml: add clear method which clears the xml doc
  Bugfix vs project template (pt.2) (openframeworks#6130)
  ...

# Conflicts:
#	libs/openFrameworks/app/ofAppGLFWWindow.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants