Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for xcode template file to allow PG to add frameworks #6174

Merged
merged 1 commit into from
Nov 11, 2018

Conversation

ofTheo
Copy link
Member

@ofTheo ofTheo commented Nov 11, 2018

fix for xcode template file to allow PG to add frameworks and fix broken projects.
closes #6172

@ofTheo ofTheo merged commit 010c4af into openframeworks:patch-release Nov 11, 2018
@ofTheo ofTheo deleted the xcode-template-fix branch November 11, 2018 16:45
@roymacdonald
Copy link
Contributor

Hi, now after this update PG fails to create working projects for xcode 8.3.2 that use frameworks as it is the case of ofxSyphon. In the past I made a fix that was properly adding the frameworks but now xcode simply complains that it can not parse the project.pbxproj file. Until which version of Xcode is going to be supported?

@ofTheo
Copy link
Member Author

ofTheo commented Nov 13, 2018

hmm @roymacdonald that is the issue this PR should of fixed.
could you try the nightly zips and see if that works for you?

@ofTheo
Copy link
Member Author

ofTheo commented Nov 13, 2018

@roymacdonald let me know if you see the issue with:
https://openframeworks.cc/ci_server/versions/nightly/of_v20181113_osx_nightly.zip

I just tried it on Xcode 9 which was having the same error you mentioned before with ofxSyphon and it works fine for me.

@roymacdonald
Copy link
Contributor

Hey @ofTheo I tried of_v20181113_osx_release and indeed it works.
Now I forced the pull from the master branch and it also works. Xcode.....
So, ignore all this.
all the best

@ofTheo
Copy link
Member Author

ofTheo commented Nov 13, 2018

Thanks @roymacdonald !! Much appreciated 👍

@roymacdonald
Copy link
Contributor

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants