Support for Android API 25 #5736

HalfdanJ · 2017-08-30T19:29:44Z

This PR is adding support for Android API 24. I had to add code requesting permissions for camera when build on more recent sdk.

Adding this allows support of ARCore for example, this requires a minSdk level of 24.

I've tested multiple apps on phones ranging from API level 19-26, all working.

…orks into android-camera-permissions

arturoc · 2017-08-31T09:54:11Z

looks good to me. perhaps the checkCameraPermission functions could be made more generic? it seems a little arbitrary to only have a permission check for that particular permission and seems like just passing the permission enum as a parameter it would work for anything no?

HalfdanJ · 2017-08-31T18:18:16Z

True, the enum is just a Java string, and sending that from c++ requires a lot of code i think, so felt this was cleaner code

…orks into android-camera-permissions

implmenting permission request and check for all permissions

bumping compileSdkVersion to include permissions as [this medium post](https://medium.com/google-developers/picking-your-compilesdkversion-minsdkversion-targetsdkversion-a098a0341ebd) says we can do it without bumping minSdkVersion

danzeeeman

+1

…era-permissions-2

HalfdanJ · 2018-03-04T17:46:43Z

This solution seems to work across all api levels from 19. I've tested in on firebase test lab that runs the camera example on physical devices on all api levels.

@arturoc , your comments should have been handled by dans commits.

HalfdanJ · 2018-03-04T19:39:05Z

libs/openFrameworksCompiled/project/android/build.gradle

        }

        ndk {
+            platformVersion = "19"


Found out this is the trick to keep NDK compiling against 19, while bumping java to 25.

Found solution here: android/ndk#126 (comment)

…era-permissions

HalfdanJ · 2018-03-04T21:43:46Z

Still passing all device tests
and travis. So should be ready to merge. @arturoc

arturoc

looks good except for the couple of things with the permissions enum, if you can change that i'll merge it

arturoc · 2018-03-05T08:52:45Z

addons/ofxAndroid/src/ofxAndroidUtils.h

@@ -78,6 +108,8 @@ void ofxAndroidUnlockScreenSleep();
 bool ofxAndroidIsOnline();
 bool ofxAndroidIsWifiOnline();
 bool ofxAndroidIsMobileOnline();
+void ofxAndroidRequestPermission(int permission);


can you change this to accept an ofxAndroidPermission instead of int?

arturoc · 2018-03-05T08:54:42Z

addons/ofxAndroid/src/ofxAndroidUtils.h

@@ -11,8 +11,38 @@
 #include "ofConstants.h"
 #include "ofEvent.h"

+
+
+enum ANDROID_PERMISSION{


This should be ofxAndroidPermission since that's the standard we use also the individual enumerations should be OFX_ANDROID_PERMISSION_READ_CALENDAR...

arturoc · 2018-03-05T08:55:53Z

addons/ofxAndroid/ofAndroidLib/src/cc/openframeworks/OFAndroid.java

@@ -54,6 +58,105 @@ private static String getPackageName(){
 		return OFAndroidLifeCycle.getActivity().getPackageName();
 	}

+	public static String parsePermission(int permission){
+		String PERMISSION = "";


this variable as all capitals in java is weird no?

arturoc · 2018-03-05T08:59:49Z

addons/ofxAndroid/ofAndroidLib/src/cc/openframeworks/OFAndroid.java

+	public static String parsePermission(int permission){
+		String PERMISSION = "";
+		switch(permission){
+			case 0:


having just numbers here looks very error prone can't we just get this value through jni's getStaticField(ID) instead of having the switch case here?

danzeeeman · 2018-03-05T15:52:19Z

yeah you can make these changes @arturoc

HalfdanJ · 2018-03-10T18:12:41Z

I gave it a pass at your comments @arturoc . I didn't use getStaticField, since the string values are the same as the constant names, so it seems like overkill. But I moved the string logic from java to c++ so there isn't any relying on the integer values.

HalfdanJ · 2018-03-10T18:31:42Z

Test fails on pulling the arturo profile picture :) Seems like the forum is down?

[  error ] ofImage: loadImage(): couldn't load image from ofBuffer, unable to guess image format from memory
[  error ] ofImage: loadImage(): couldn't load image from ""https://forum.openframeworks.cc/user_avatar/forum.openframeworks.cc/arturo/45/3965_1.png""

arturoc · 2018-03-11T13:47:14Z

thanks so much jonas, that looks great. i broke the forum yesterday trying to update it, it's already working on a new server but we still have to change the dns entry. as soon as that's ready i'll restart the tests and merge this

nishimotz · 2018-04-10T01:57:26Z

androidAudioExample raises error as follows and audio input is not working.

04-09 19:09:33.299   203 27094 W ServiceManager: Permission failure: android.permission.RECORD_AUDIO from uid=10197 pid=27011
04-09 19:09:33.299   203 27094 E         : Request requires android.permission.RECORD_AUDIO
04-09 19:09:33.299   203 27094 E AudioFlinger: openRecord() permission denied: recording not allowed
04-09 19:09:33.300 27011 27038 E AudioRecord: AudioFlinger could not create record track, status: -1
04-09 19:09:33.302   203 27046 I AudioFlinger: AudioFlinger's thread 0xb2600000 ready to run
04-09 19:09:33.306 27011 27038 E AudioRecord-JNI: Error creating AudioRecord instance: initialization check failed with status -1.
04-09 19:09:33.306 27011 27038 E android.media.AudioRecord: Error code -20 when initializing native AudioRecord object.
04-09 19:09:33.306 27011 27038 I OF      : sound input setup with buffersize: 3552
04-09 19:09:33.309 27011 27038 I ofAppAndroidWindow: resize 1080x1776
04-09 19:09:33.310 27011 27047 I OF      : no audio input

danzeeeman · 2018-04-10T13:07:16Z

Permissions issue

…

On Mon, Apr 9, 2018, 9:57 PM Takuya Nishimoto ***@***.***> wrote: androidAudioExample raises error as follows and audio input is not working. 04-09 19:09:33.299 203 27094 W ServiceManager: Permission failure: android.permission.RECORD_AUDIO from uid=10197 pid=27011 04-09 19:09:33.299 203 27094 E : Request requires android.permission.RECORD_AUDIO 04-09 19:09:33.299 203 27094 E AudioFlinger: openRecord() permission denied: recording not allowed 04-09 19:09:33.300 27011 27038 E AudioRecord: AudioFlinger could not create record track, status: -1 04-09 19:09:33.302 203 27046 I AudioFlinger: AudioFlinger's thread 0xb2600000 ready to run 04-09 19:09:33.306 27011 27038 E AudioRecord-JNI: Error creating AudioRecord instance: initialization check failed with status -1. 04-09 19:09:33.306 27011 27038 E android.media.AudioRecord: Error code -20 when initializing native AudioRecord object. 04-09 19:09:33.306 27011 27038 I OF : sound input setup with buffersize: 3552 04-09 19:09:33.309 27011 27038 I ofAppAndroidWindow: resize 1080x1776 04-09 19:09:33.310 27011 27047 I OF : no audio input — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#5736 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAr6zOFa6EnlqdLt1aGZwPv4vp4uYENwks5tnBGRgaJpZM4PH3Tu> .

danzeeeman · 2018-04-10T13:09:16Z

The audio example just need to be updated to request permission to record audio

…

On Tue, Apr 10, 2018, 9:07 AM Dan Moore ***@***.***> wrote: Permissions issue On Mon, Apr 9, 2018, 9:57 PM Takuya Nishimoto ***@***.***> wrote: > androidAudioExample raises error as follows and audio input is not > working. > > 04-09 19:09:33.299 203 27094 W ServiceManager: Permission failure: android.permission.RECORD_AUDIO from uid=10197 pid=27011 > 04-09 19:09:33.299 203 27094 E : Request requires android.permission.RECORD_AUDIO > 04-09 19:09:33.299 203 27094 E AudioFlinger: openRecord() permission denied: recording not allowed > 04-09 19:09:33.300 27011 27038 E AudioRecord: AudioFlinger could not create record track, status: -1 > 04-09 19:09:33.302 203 27046 I AudioFlinger: AudioFlinger's thread 0xb2600000 ready to run > 04-09 19:09:33.306 27011 27038 E AudioRecord-JNI: Error creating AudioRecord instance: initialization check failed with status -1. > 04-09 19:09:33.306 27011 27038 E android.media.AudioRecord: Error code -20 when initializing native AudioRecord object. > 04-09 19:09:33.306 27011 27038 I OF : sound input setup with buffersize: 3552 > 04-09 19:09:33.309 27011 27038 I ofAppAndroidWindow: resize 1080x1776 > 04-09 19:09:33.310 27011 27047 I OF : no audio input > > — > You are receiving this because your review was requested. > Reply to this email directly, view it on GitHub > <#5736 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAr6zOFa6EnlqdLt1aGZwPv4vp4uYENwks5tnBGRgaJpZM4PH3Tu> > . >

arturoc · 2018-04-10T13:15:17Z

I just checked and the permissions seem to be ok, perhaps this is an issue with the PG overwriting the manifest or something? @nishimotz can you open a new issue? i doubt this is related to the update to android 25

danzeeeman · 2018-04-10T14:42:43Z

No, in Android 25 if your phone is that API level or higher it changes to the runtime permissions check. So it ignores the manifest and requires the user to give permission. These two logs show that is the case Request requires android.permission.RECORD_AUDIO openRecord() permission denied: recording not allowed

HalfdanJ · 2018-04-10T15:05:35Z

Right, it's still needed on the manifest file, but we need to call the request permission function call somewhere since recording audio is probably a "dangerous permission". We should probably do it on the audio recorder code like we do with the video input.

danzeeeman · 2018-04-10T15:14:14Z

oh I thought you could strip it from the manifest and just ask for it at runtime?

…

On Tue, Apr 10, 2018 at 11:06 AM, Jonas Jongejan ***@***.***> wrote: Right, it's still needed on the manifest file, but we need to call the request permission function call somewhere since recording audio is probably a "dangerous permission". We should probably do it on the audio recorder code like we do with the video input. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#5736 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAr6zEZo2fx-UD_YR6tR0mDTlxOOwx6yks5tnMpYgaJpZM4PH3Tu> .

-- Dan Moore makeitdoathing.com @theDANtheMAN dan@makeitdoathing.com

HalfdanJ · 2018-04-10T15:18:58Z

No the manifest is still needed. That is what indicates what might be asked (for example shown on play store).

danzeeeman · 2018-04-10T15:36:43Z

yeah

…

On Tue, Apr 10, 2018 at 11:19 AM, Jonas Jongejan ***@***.***> wrote: No the manifest is still needed. That is what indicates what might be asked (for example shown on play store). — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#5736 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAr6zHea2K1SUS-1ca1uvnqsaZnqSzC7ks5tnM1xgaJpZM4PH3Tu> .

-- Dan Moore makeitdoathing.com @theDANtheMAN dan@makeitdoathing.com

nishimotz · 2018-04-24T12:32:01Z

@arturoc As reported in #5963, I doubt this is permission problem as well. ofSoundStream seems broken.

Jonas Jongejan added 7 commits August 12, 2017 22:20

Update android to SDK 24 and NDK 15c

8b8ddf7

Ignore files generated in android examples by project generator

1a3e8e8

Update android template

f61653b

Check camera permissions in android sdk 22

7ecaa2a

Request permissions work

5fbc26c

Merge branch 'master' of https://github.com/openframeworks/openFramew…

e9e1687

…orks into android-camera-permissions

Rollback sdk requirements

1598fb9

HalfdanJ added the android label Aug 30, 2017

HalfdanJ requested a review from arturoc August 30, 2017 19:29

roolback buildtools version

81db579

HalfdanJ requested a review from danzeeeman August 31, 2017 18:18

Dan Moore added 3 commits February 8, 2018 13:56

Merge branch 'master' of https://github.com/openFrameworks/openFramew…

eba02e1

…orks into android-camera-permissions

implmenting permission request and check

4f5e415

implmenting permission request and check for all permissions

compileSdkVersion to 25

7224e4a

bumping compileSdkVersion to include permissions as [this medium post](https://medium.com/google-developers/picking-your-compilesdkversion-minsdkversion-targetsdkversion-a098a0341ebd) says we can do it without bumping minSdkVersion

danzeeeman mentioned this pull request Feb 8, 2018

openCV Example and common-functions cleanup #5883

Closed

danzeeeman reviewed Feb 8, 2018

View reviewed changes

Merge remote-tracking branch 'openframeworks/master' into android-cam…

a1d22a3

…era-permissions-2

Jonas Jongejan added 2 commits March 4, 2018 13:40

Fix travis settings for android

223c4dc

Set target sdk version to 25

ba5412d

HalfdanJ commented Mar 4, 2018

View reviewed changes

Set camera to be initialized on app resume

10026cd

HalfdanJ changed the title ~~Support for Android API 24~~ Support for Android API 25 Mar 4, 2018

Jonas Jongejan added 2 commits March 4, 2018 15:05

Merge remote-tracking branch 'openframeworks/master' into android-cam…

6f64ed4

…era-permissions

Travis fix

c82ba77

arturoc requested changes Mar 5, 2018

View reviewed changes

Android permission refactor

804e223

arturoc approved these changes Mar 11, 2018

View reviewed changes

arturoc merged commit 7978597 into openframeworks:master Mar 11, 2018

nishimotz mentioned this pull request Apr 10, 2018

androidAudioExample not working #5963

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for Android API 25 #5736

Support for Android API 25 #5736

HalfdanJ commented Aug 30, 2017

arturoc commented Aug 31, 2017

HalfdanJ commented Aug 31, 2017

danzeeeman left a comment

HalfdanJ commented Mar 4, 2018 •

edited

Loading

HalfdanJ Mar 4, 2018

HalfdanJ Mar 4, 2018

HalfdanJ commented Mar 4, 2018

arturoc left a comment

arturoc Mar 5, 2018

arturoc Mar 5, 2018

arturoc Mar 5, 2018

arturoc Mar 5, 2018

danzeeeman commented Mar 5, 2018

HalfdanJ commented Mar 10, 2018

HalfdanJ commented Mar 10, 2018

arturoc commented Mar 11, 2018

nishimotz commented Apr 10, 2018

danzeeeman commented Apr 10, 2018 via email

danzeeeman commented Apr 10, 2018 via email

arturoc commented Apr 10, 2018

danzeeeman commented Apr 10, 2018 via email •

edited

Loading

HalfdanJ commented Apr 10, 2018

danzeeeman commented Apr 10, 2018 via email

HalfdanJ commented Apr 10, 2018

danzeeeman commented Apr 10, 2018 via email

nishimotz commented Apr 24, 2018

Support for Android API 25 #5736

Support for Android API 25 #5736

Conversation

HalfdanJ commented Aug 30, 2017

arturoc commented Aug 31, 2017

HalfdanJ commented Aug 31, 2017

danzeeeman left a comment

Choose a reason for hiding this comment

HalfdanJ commented Mar 4, 2018 • edited Loading

HalfdanJ Mar 4, 2018

Choose a reason for hiding this comment

HalfdanJ Mar 4, 2018

Choose a reason for hiding this comment

HalfdanJ commented Mar 4, 2018

arturoc left a comment

Choose a reason for hiding this comment

arturoc Mar 5, 2018

Choose a reason for hiding this comment

arturoc Mar 5, 2018

Choose a reason for hiding this comment

arturoc Mar 5, 2018

Choose a reason for hiding this comment

arturoc Mar 5, 2018

Choose a reason for hiding this comment

danzeeeman commented Mar 5, 2018

HalfdanJ commented Mar 10, 2018

HalfdanJ commented Mar 10, 2018

arturoc commented Mar 11, 2018

nishimotz commented Apr 10, 2018

danzeeeman commented Apr 10, 2018 via email

danzeeeman commented Apr 10, 2018 via email

arturoc commented Apr 10, 2018

danzeeeman commented Apr 10, 2018 via email • edited Loading

HalfdanJ commented Apr 10, 2018

danzeeeman commented Apr 10, 2018 via email

HalfdanJ commented Apr 10, 2018

danzeeeman commented Apr 10, 2018 via email

nishimotz commented Apr 24, 2018

HalfdanJ commented Mar 4, 2018 •

edited

Loading

danzeeeman commented Apr 10, 2018 via email •

edited

Loading