openCV Example and common-functions cleanup #5883

danzeeeman · 2018-02-08T16:35:38Z

This contains the needed things in the android-r15 branch to update the CV example and to fix the common-functions. When we can bump from API 19 to API 24 the other stuff needs to be merged but the branch is crap. I'll move them to an android-api-24 branch that will also need its own libs. >=API-24 is only at 29.6% so we can't bump it yet.

danzeeeman · 2018-02-08T19:22:42Z

ok well see PR #5736 and https://medium.com/google-developers/picking-your-compilesdkversion-minsdkversion-targetsdkversion-a098a0341ebd

arturoc · 2018-02-09T09:20:00Z

Just tested this by reenabling the opencv example here: #5864 but it's still failing. Not sure if we need some bits from your old PR too?

Btw, please be careful to not create PRs with branches directly in the main repo, it triggers the tests twice + i need to go later through everyone's branches to see what's still open in order to delete the old ones

I'm going to close this, can you open a new PR from your repo with the bits necessary from your old one ( i believe that one fixed the problem with finding the addon headers) this and #5864 which re-enables the tests for addons examples?

danzeeeman · 2018-02-09T14:01:54Z

this builds and compiles on my machine. why is it failing on CI?

…

On Fri, Feb 9, 2018 at 4:20 AM, arturo ***@***.***> wrote: Closed #5883 <#5883>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5883 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAr6zD_45-hnQaMcNm2nohAnjyC7hdcmks5tTA3SgaJpZM4R-plP> .

-- Dan Moore makeitdoathing.com @theDANtheMAN dan@makeitdoathing.com

danzeeeman · 2018-02-09T14:01:56Z

I'm not closing this @arturoc.
this needs to be merged.

arturoc · 2018-02-09T14:12:09Z

what is this fixing? as i said i tried re-enabling the opencv example but it's not working. might it be that you have some additional changes that are not in this PR or something.

It doesn't look like the parsing of the addons is being fixed in this PR which is what seems to be failing.

The previous PR you sent seems to fix that but then it complains about android-24 not being present..

In any case can you send this from your repo instead of the OF one?

danzeeeman · 2018-02-09T14:15:25Z

did you check out the branch and run the example from your own machine or did you just check the CI? Its on the main repo so you can git checkout branch-name and not have to add my repo to your remotes. can you actually check this on your machine and not pay attention to CI?

…

On Fri, Feb 9, 2018 at 9:12 AM, arturo ***@***.***> wrote: what is this fixing? as i said i tried re-enabling the opencv example but it's not working. might it be that you have some additional changes that are not in this PR or something. It doesn't look like the parsing of the addons is being fixed in this PR which is what seems to be failing. The previous PR you sent seems to fix that but then it complains about android-24 not being present.. In any case can you send this from your repo instead of the OF one? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#5883 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAr6zI1gpiTcQ6DKTfb5CW7MzGdcdVS1ks5tTFJGgaJpZM4R-plP> .

-- Dan Moore makeitdoathing.com @theDANtheMAN dan@makeitdoathing.com

arturoc · 2018-02-09T14:20:06Z

it seems to compile in my machine but so does current master so not sure what's the problem or what is this fixing?

danzeeeman · 2018-02-09T15:31:15Z

part of it was to update the example to modern OF calls and correct things. the second is that it cleaned up the print output from the common-functions.gradle as requested from Zach to make things easier to understand what is happening during the build process. the third was fixing how it added recursive paths in addons.

…

On Fri, Feb 9, 2018 at 9:20 AM, arturo ***@***.***> wrote: it seems to compile in my machine but so does current master so not sure what's the problem or what is this fixing? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#5883 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAr6zNjfRuK3Mt3zUp4jTcdy7TcnRUffks5tTFQogaJpZM4R-plP> .

-- Dan Moore makeitdoathing.com @theDANtheMAN dan@makeitdoathing.com

danzeeeman · 2018-02-09T15:32:14Z

ofGetSystemTime() is deprecated

…

On Fri, Feb 9, 2018 at 10:30 AM, Dan Moore ***@***.***> wrote: part of it was to update the example to modern OF calls and correct things. the second is that it cleaned up the print output from the common-functions.gradle as requested from Zach to make things easier to understand what is happening during the build process. the third was fixing how it added recursive paths in addons. On Fri, Feb 9, 2018 at 9:20 AM, arturo ***@***.***> wrote: > it seems to compile in my machine but so does current master so not sure > what's the problem or what is this fixing? > > — > You are receiving this because you modified the open/close state. > Reply to this email directly, view it on GitHub > <#5883 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAr6zNjfRuK3Mt3zUp4jTcdy7TcnRUffks5tTFQogaJpZM4R-plP> > . > -- Dan Moore makeitdoathing.com @theDANtheMAN ***@***.***

-- Dan Moore makeitdoathing.com @theDANtheMAN dan@makeitdoathing.com

arturoc · 2018-02-19T09:54:57Z

I've just tested this again in my computer but completely cleaning the projects first and it seems to be failing with the same errors as the CI servers.

The steps to reproduce it:

rm -r examples/android/androidOpenCVExample/
git checkout examples/android/androidOpenCVExample/

to completely clean the example without having to download a clean OF install but downloading OF from github or the nightlies fails with the same error. This are the steps i'm following in my computer to generate and compile the example from a clean OF from github

scripts/android/download_libs.sh
/home/arturo/apps/android-studio/gradle/gradle-4.1/bin/gradle wrapper --gradle-version 3.3
projectGenerator -p"android" -o"/home/arturo/Code/openFrameworks" /home/arturo/Code/openFrameworks/examples/android/androidOpenCVExample
echo ndk.dir=/home/arturo/Code/android-ndk-r15c > examples/android/androidOpenCVExample/local.properties
echo sdk.dir=/home/arturo/Code/android-sdk >> examples/android/androidOpenCVExample/local.properties
./gradlew -b /home/arturo/Code/openFrameworks/examples/android/androidOpenCVExample/build.gradle compileArm7DebugSources

that fails with:

 file included from /home/arturo/Code/openFrameworks/examples/android/androidOpenCVExample/src/ofApp.cpp:1:
/home/arturo/Code/openFrameworks/examples/android/androidOpenCVExample/src/ofApp.h:6:10: fatal error: 'ofxOpenCv.h' file not found
#include "ofxOpenCv.h"
         ^~~~~~~~~~~~~
1 error generated.

In file included from /home/arturo/Code/openFrameworks/examples/android/androidOpenCVExample/src/main.cpp:2:
/home/arturo/Code/openFrameworks/examples/android/androidOpenCVExample/src/ofApp.h:6:10: fatal error: 'ofxOpenCv.h' file not found
#include "ofxOpenCv.h"
         ^~~~~~~~~~~~~
1 error generated.

:compileOFAndroidAppArmeabi-v7aDebugArm7SharedLibraryOFAndroidAppArmeabi-v7aDebugArm7SharedLibraryMainCpp FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileOFAndroidAppArmeabi-v7aDebugArm7SharedLibraryOFAndroidAppArmeabi-v7aDebugArm7SharedLibraryMainCpp'.
> Multiple build operations failed.
      C++ compiler failed while compiling ofApp.cpp.
      C++ compiler failed while compiling main.cpp.
  See the complete log at: file:///home/arturo/Code/openFrameworks/examples/android/androidOpenCVExample/build/tmp/compileOFAndroidAppArmeabi-v7aDebugArm7SharedLibraryOFAndroidAppArmeabi-v7aDebugArm7SharedLibraryMainCpp/output.txt

that last output.txt file has the compiler output which shows a bunch of warnings and the previous error.

I've also tried to use android studio ide instead of command line but then i can't even start to compile. first i get something about an output folder not set for the project, by setting one manually in some config settings that open up then i get:

Error:Failed to load project configuration: cannot read file /home/arturo/Downloads/of_v20180215_android_release/examples/android/androidOpenCVExample/.idea/misc.xml: /home/arturo/Downloads/of_v20180215_android_release/examples/android/androidOpenCVExample/.idea/misc.xml (No such file or directory)

arturoc · 2018-03-04T18:13:08Z

just fixed this with #5908 going to close this PR since i think everything it's there already but let me know if you think i'm missing something

HalfdanJ · 2018-03-04T18:22:23Z

Ah great! Then ill stop debugging (was trying to replicate the problem as you closed it)

openCV Example and common-functions cleanup

046c576

arturoc mentioned this pull request Feb 9, 2018

testing android opencv is fixed #5885

Closed

arturoc closed this Feb 9, 2018

danzeeeman reopened this Feb 9, 2018

HalfdanJ mentioned this pull request Mar 4, 2018

updating openCV android example #5779

Closed

Jonas Jongejan added 3 commits March 4, 2018 13:00

Merge remote-tracking branch 'openframeworks/master' into android-opencv

2fc67eb

Update andriod opencv manifest file

968cb7c

Enable opencv test on travis

a1cfcd1

arturoc closed this Mar 4, 2018

arturoc deleted the android-opencv branch March 4, 2018 18:13

arturoc restored the android-opencv branch March 4, 2018 18:13

arturoc deleted the android-opencv branch March 4, 2018 18:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

openCV Example and common-functions cleanup #5883

openCV Example and common-functions cleanup #5883

danzeeeman commented Feb 8, 2018

danzeeeman commented Feb 8, 2018

arturoc commented Feb 9, 2018

danzeeeman commented Feb 9, 2018 via email

danzeeeman commented Feb 9, 2018

arturoc commented Feb 9, 2018

danzeeeman commented Feb 9, 2018 via email

arturoc commented Feb 9, 2018

danzeeeman commented Feb 9, 2018 via email

danzeeeman commented Feb 9, 2018 via email

arturoc commented Feb 19, 2018

arturoc commented Mar 4, 2018

HalfdanJ commented Mar 4, 2018

openCV Example and common-functions cleanup #5883

openCV Example and common-functions cleanup #5883

Conversation

danzeeeman commented Feb 8, 2018

danzeeeman commented Feb 8, 2018

arturoc commented Feb 9, 2018

danzeeeman commented Feb 9, 2018 via email

danzeeeman commented Feb 9, 2018

arturoc commented Feb 9, 2018

danzeeeman commented Feb 9, 2018 via email

arturoc commented Feb 9, 2018

danzeeeman commented Feb 9, 2018 via email

danzeeeman commented Feb 9, 2018 via email

arturoc commented Feb 19, 2018

arturoc commented Mar 4, 2018

HalfdanJ commented Mar 4, 2018