-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
of::filesystem PR #7110
of::filesystem PR #7110
Conversation
General changes (namespace, deprecated loadFile function) (openframeworks#7344)
This PR is finally complete, I think having to append .string() to convert a path to a string is a good change, so people can consciously convert the path to string, or u8string when needed of::filesystem::path path{u8"愛.txt"};
std::u8string path_string{path.u8string()}; But I would like to invite others to give opinion on this: @artificiel @ofTheo @2bbb @NickHardeman |
hi! @dimitre I think what we have explicit way to convert is good. |
Thanks for those thoughts!
One thing we could do if we want to merge this sooner is keep the string return types, merge this PR and put the path return types in a seperate PR.
This would give a bit more time to think about strategy. I agree though this is ultimately the way to go, just don’t want to break a ton of addons, examples and projects without a bit more planning.
|
Great @ofTheo I've just did that |
Thanks @dimitre ! 🎉🎉🎉👏 |
relates to:
#6585
specifically:
#6585 (comment)