General changes (namespace, deprecated loadFile function) #7344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofTheo
reviewed
Feb 24, 2023
addons/ofxGui/src/ofxSliderGroup.cpp
Outdated
| @@ -130,7 +129,7 @@ ofxColorSlider_<ColorType> * ofxColorSlider_<ColorType>::setup(ofParameter<ofCol | |||
| ofxGuiGroup::setup(value.getName(), "", 0, 0); | |||
| parameters.clear(); | |||
|
|
|||
| const string names[4] = {"r", "g", "b", "a"}; | |||
| const std::tring names[4] = {"r", "g", "b", "a"}; | |||
There was a problem hiding this comment.
think this might be a typo?
tring -> string
There was a problem hiding this comment.
good to merge once this is fixed :)
dimitre
added a commit
to dimitre/openFrameworks
that referenced
this pull request
Feb 25, 2023
General changes (namespace, deprecated loadFile function) (openframeworks#7344)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in some more files
This is meant to remove unrelated changes in this big PR - #7110