Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: controller service pattern for user api #195

Merged
merged 4 commits into from
Jun 20, 2020
Merged

refactor: controller service pattern for user api #195

merged 4 commits into from
Jun 20, 2020

Conversation

JasonChong96
Copy link
Contributor

@JasonChong96 JasonChong96 commented Jun 16, 2020 •
edited
Loading

Problem

#156
The backend structure is inconsistent and refactoring is incomplete.

Solution

This PR continues the refactoring process by refactoring user endpoints

Additional notes

@JasonChong96 JasonChong96 marked this pull request as ready for review June 17, 2020 12:40
@JasonChong96 JasonChong96 mentioned this pull request Jun 18, 2020
Merged
7 tasks
yong-jie
yong-jie approved these changes Jun 20, 2020
View reviewed changes
Copy link
Member

@yong-jie yong-jie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Abstracting these handlers into their own functions will finally allow us to write tests for /user api endpoints

@JasonChong96 JasonChong96 merged commit 380a142 into develop Jun 20, 2020
@JasonChong96 JasonChong96 deleted the refactor-user branch June 20, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yong-jie yong-jie yong-jie approved these changes

@liangyuanruo liangyuanruo Awaiting requested review from liangyuanruo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonChong96 @yong-jie