fix: add return after making server response #2074
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In two places in the codebase, the server does not return immediately after making a response, leading to
res.send()
being called twice, which causes an unhandled promise rejection. This is still okay for node <14 because it just gives a warning, but not from node 15 onwards (see node 15 release docs) as it throws an error and terminates the entire node process, which is very scary.Example error message:
Solution
UserController
: simply addreturn
LinkAuditController
: had to invert the logic a little to do the same functionality without callingres.send()
twice