fix: handle unhandled nodejs rejections #2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halfwhole
changed the title
2 tasks
gweiying
reviewed
Nov 15, 2022
gweiying
reviewed
Dec 6, 2022
gweiying
approved these changes
Dec 6, 2022
halfwhole
force-pushed
the
fix/handle-unhandled-rejections
branch
from
f599a0b to
94f6e83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Unhandled rejections can arise due to situations like in #2074. In the event that such a situation occurs and we've upgraded to node 16, unhandled rejections will cause node to crash.
Solution
Handle unhandled rejections in the node process, preventing the process from crashing.
Screenshot (after) for a sample logger error message, when there's an unhandled rejection:
Deploy notes
Post-deploy: create datadog metric for unhandled nodejs rejections