feat(helmet): implement CSP policy #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangyuanruo
approved these changes
Jul 27, 2020
Tighten how the browser interacts with the rest of the world when accessing go.gov.sg. Avoid having to inject a nonce into the transition page by moving the sole inline script into its own templated file. - specify a content security policy using helmet - allow requests from Google, Sentry (if present) - move inline script in transition-page.ejs to its own template, and map this to `/assets/transition-page/js/gtag.js` New env variables: `CSP_ONLY_REPORT_VIOLATIONS` - when true, only reports CSP violations `CSP_REPORT_URI` - the URI that a browser can POST CSP violations to
LoneRifle
force-pushed
the
feat/helmet/csp
branch
from
48af247 to
9ace5b9
Compare
LoneRifle
added a commit
that referenced
this pull request
Jul 29, 2020
This reverts commit f584eba.
LoneRifle
added a commit
that referenced
this pull request
Jul 29, 2020
LoneRifle
added a commit
that referenced
this pull request
Jul 29, 2020
This reverts commit a9f62df.
xming13
pushed a commit
to xming13/GoGovSG
that referenced
this pull request
Aug 21, 2020
Tighten how the browser interacts with the rest of the world when accessing go.gov.sg. Avoid having to inject a nonce into the transition page by moving the sole inline script into its own templated file. - specify a content security policy using helmet - allow requests from Google, Sentry (if present) - move inline script in transition-page.ejs to its own template, and map this to `/assets/transition-page/js/gtag.js` New env variables: `CSP_ONLY_REPORT_VIOLATIONS` - when true, only reports CSP violations `CSP_REPORT_URI` - the URI that a browser can POST CSP violations to
xming13
pushed a commit
to xming13/GoGovSG
that referenced
this pull request
Aug 21, 2020
This reverts commit f584eba.
xming13
pushed a commit
to xming13/GoGovSG
that referenced
this pull request
Aug 21, 2020
This reverts commit a9f62df.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #291
Solution
Tighten how the browser interacts with the rest of the world when
accessing go.gov.sg. Avoid having to inject a nonce into the transition
page by moving the sole inline script into its own templated file.
map this to
/assets/transition-page/js/gtag.jsScreenshots
Deploy Notes
New environment variables:
CSP_ONLY_REPORT_VIOLATIONS- when true, only reports CSP violationsCSP_REPORT_URI- the URI that a browser can POST CSP violations to